Fixes #93 by passing full URI to redis.createClient when specified #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @objectiveSee, thanks for taking a look at this. I've made the suggested review markup and pushed to the PR branch. Is there anything else I can do to help move this PR along? |
Closed
|
Hi @objectiveSee, @BridgeAR. Having reviewed this, would you be happy to merge it? - It's been open for a while now (also mentioning @rauchg as the primary maintainer). |
|
Thank you ! |
|
Thanks @rauchg. Do you know when you'll next be publishing this package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial approach was to use
url.parse()from the Node.js URL module to get the hostname and port. This did work, but I noticed that redis also lets you specify the database index and other options via the URL, so it seemed better to pass it wholesale to thecreateClientcall if specified.