Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeStack] headerBlurEffect: "extraLight" has no effect #2320

Closed
stanleyoos opened this issue Aug 28, 2024 · 0 comments · Fixed by #2338
Closed

[NativeStack] headerBlurEffect: "extraLight" has no effect #2320

stanleyoos opened this issue Aug 28, 2024 · 0 comments · Fixed by #2338
Assignees
@maksg @kkafar
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@stanleyoos
Copy link

stanleyoos commented Aug 28, 2024 •
edited
Loading

Description

I want to use headerBlurEffect in NativeStack with value "extraLight" , but it seems to have no effect

2024-08-07.at.09.46.39.mp4

Same issue in react-navigation repo

Steps to reproduce

  1. clone the repo provided below
  2. npm install && npm start
  3. change the value of headerBlurEffect to "extraLight" as shown on the video

Snack or a link to a repository

https://github.com/stanleyoos/native-stack-reproduction

Screens version

3.31.1

React Native version

0.74.3

Platforms

iOS

JavaScript runtime

Hermes

Workflow

Expo managed workflow

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

iOS simulator

Device model

iPhone 15 Pro (iOS 17.0)

Acknowledgements

Yes
@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided labels Aug 28, 2024
@software-mansion software-mansion deleted a comment Aug 28, 2024
@maksg maksg self-assigned this Sep 6, 2024
@maksg maksg mentioned this issue Sep 10, 2024
Merged
2 tasks
@kkafar kkafar self-assigned this Oct 18, 2024
@kkafar kkafar closed this as completed in fcb1693 Oct 18, 2024
kkafar pushed a commit that referenced this issue Oct 25, 2024
@maksg @kkafar
fix(iOS): extraLight blur not working (#2338)
da70a27 
Blur style `UIBlurEffectStyleExtraLight` equals `0` so using it in `if
(config.blurEffect)` makes it that the code for applying
`backgroundEffect` doesn't execute.

With this fix the navigation bar can no longer be fully transparent
because blur effect is always set as `extraLight` by default. So it's up
for a discussion if it should stay that way or if we should make this
value optional.

Fixes #2320.

Added `Test2320` to tests.

- [x] Included code example that can be used to test this change
- [ ] Ensured that CI passes

---------

Co-authored-by: Kacper Kafara <[email protected]>
(cherry picked from commit fcb1693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksg maksg

@kkafar kkafar

Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iOS): extraLight blur not working software-mansion/react-native-screens
3 participants
@maksg @stanleyoos @kkafar