fix(iOS): extraLight blur not working
#2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Good catch, but we rather don't want to go this way.
Let's add a option unspecified, but only for internal API usage (do not include this option in public API), and when blurEffect has undefined / nullish value, in bottom-level Screen component (just in the wrapper for NativeScreenComponent) let's make use of this Unspecified / Undefined enum variant and pass it to native side. Then in headerConfig check for variant value.
Does that sound right?
|
@kkafar I added custom enum value |
|
I'll merge this once CI passes. |
kkafar
pushed a commit
that referenced
this pull request
Oct 25, 2024
Blur style `UIBlurEffectStyleExtraLight` equals `0` so using it in `if (config.blurEffect)` makes it that the code for applying `backgroundEffect` doesn't execute. With this fix the navigation bar can no longer be fully transparent because blur effect is always set as `extraLight` by default. So it's up for a discussion if it should stay that way or if we should make this value optional. Fixes #2320. Added `Test2320` to tests. - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]> (cherry picked from commit fcb1693)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blur style
UIBlurEffectStyleExtraLightequals0so using it inif (config.blurEffect)makes it that the code for applyingbackgroundEffectdoesn't execute.With this fix the navigation bar can no longer be fully transparent because blur effect is always set as
extraLightby default. So it's up for a discussion if it should stay that way or if we should make this value optional.Fixes #2320.
Test code and steps to reproduce
Added
Test2320to tests.Checklist