Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Rename nonce instructions with VerbNoun scheme #607

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

t-nelson
Copy link
Contributor

Rename nonce instructions to match main code base

Depends on solana-labs/solana#7775

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the Accounts seem superfluous to me (except in the case of Withdraw, which is maybe most correct as WithdrawFromNonceAccount). But if @garious liked it upstream, I guess :shipit: !

@t-nelson
Copy link
Contributor Author

Agreed *Account seemed like too much. But without seemed like too little, so I erred on the side of verbosity

@t-nelson t-nelson merged commit 77d63b1 into solana-labs:master Jan 13, 2020
@t-nelson t-nelson deleted the rename_nonce_ix branch January 13, 2020 23:59
@codecov-io
Copy link

Codecov Report

Merging #607 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          25       25           
  Lines        1010     1010           
  Branches      128      128           
=======================================
  Hits          741      741           
  Misses        236      236           
  Partials       33       33
Impacted Files Coverage Δ
src/transaction.js 94.76% <ø> (ø) ⬆️
src/system-program.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a47b4...3dc91ad. Read the comment docs.

@mvines
Copy link
Contributor

mvines commented Jan 14, 2020

🎉 This PR is included in version 0.29.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants