This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Nonce: Rename instructions with VerbNoun scheme #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
approved these changes
Jan 13, 2020
t-nelson
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #7775 +/- ##
========================================
+ Coverage 81.8% 81.8% +<.1%
========================================
Files 238 241 +3
Lines 50993 51020 +27
========================================
+ Hits 41730 41761 +31
+ Misses 9263 9259 -4 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2020
automerge (cherry picked from commit 81ae44f) # Conflicts: # sdk/src/system_instruction.rs
t-nelson
added a commit
that referenced
this pull request
Jan 17, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After move to system program, nonce instructions do not follow VerbNoun naming scheme
Summary of Changes
Rename them