Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make useHref return a string with string param #505

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sugar700
Copy link

@sugar700 sugar700 commented Jan 3, 2025

This avoids the need to handle an undefined value when the destination parameter is known to be a string.

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: f9b6dc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sugar700 sugar700 force-pushed the make-use-href-not-return-null-with-string-parameter branch from 0de6da1 to 10b398f Compare January 16, 2025 06:03
sugar700 and others added 2 commits January 16, 2025 07:04
This avoids the need to handle an undefined value when the destination
parameter is known to be a string.
@sugar700 sugar700 force-pushed the make-use-href-not-return-null-with-string-parameter branch from 10b398f to f9b6dc6 Compare January 16, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants