Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make useHref return a string with string param #505

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make useHref return a string with string param #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a4ec21
Make useHref return a string with string param
sugar700 Jan 3, 2025
f9b6dc6
Create stupid-trainers-shake.md
ryansolid Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-trainers-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/router": patch
---

Make useHref return a string with string param
2 changes: 1 addition & 1 deletion src/routing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const useResolvedPath = (path: () => string) => {
return createMemo(() => route.resolvePath(path()));
};

export const useHref = (to: () => string | undefined) => {
export const useHref = <T extends string | undefined>(to: () => T): () => string | T => {
const router = useRouter();
return createMemo(() => {
const to_ = to();
Expand Down
Loading