Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Deprecate Spree::Address#empty?" #1685

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Revert "Deprecate Spree::Address#empty?" #1685

merged 1 commit into from
Jan 16, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Jan 16, 2017 •
edited
Loading

Reverts #1680

This caused test failures which were for some reason not caught in the PR.

@jhawthorn
Copy link
Contributor Author

I figured it out. PRs didn't have the CircleCI config which caused them to fail on depredations. Fixed now in CircleCI config 🙄

@jhawthorn jhawthorn merged commit 1420aaa into master Jan 16, 2017
@jhawthorn jhawthorn deleted the revert-1680-deprecate_address_empty branch January 16, 2017 22:12
@cbrunsdon
Copy link
Contributor

Now we have to live with those red ❌'s forever.

@jhawthorn jhawthorn mentioned this pull request Jan 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhawthorn @cbrunsdon