Deprecate Address#empty? #1686
Merged
Deprecate Address#empty? #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would return Address#empty?, but an Address should always be considered present.
Previously, this would only check the box if the two addresses were identical AND they were both "empty". Instead, this now checks "Use billing" any time the two addresses are equal and the ship_address is a new record. I think this was probably the original intention of checking empty? (only new records can be empty because of Address's validations).
jhawthorn
force-pushed
the
deprecate_address_empty_take_2
branch
from
f7d54fa to
57b005a
Compare
cbrunsdon
approved these changes
Jan 19, 2017
JuanCrg90
added a commit
to JuanCrg90/solidus_taxjar
that referenced
this pull request
Mar 12, 2019
Solidus has deprecated the `empty?` method on solidusio/solidus#1686 . This adds a private `empty?` method for avoid future problems and remove the deprecation warning in projects that uses this gem.
JuanCrg90
added a commit
to JuanCrg90/solidus_taxjar
that referenced
this pull request
Mar 12, 2019
Solidus has deprecated the `empty?` method on solidusio/solidus#1686 . This adds a private `empty?` method for avoid future problems and remove the deprecation warning in projects that uses this gem.
JuanCrg90
added a commit
to JuanCrg90/solidus_taxjar
that referenced
this pull request
Mar 12, 2019
Solidus has deprecated the `empty?` method on solidusio/solidus#1686 . This adds a private `incomplete_address?` method for avoid future problems and remove the deprecation warning in projects that uses this gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #1685 was reverted. It was causing errors due to a deprecation (which wasn't caught due to CircleCI configuration).
In addition to deprecating
Address#empty?this changes the "Use billing" checkbox in the admin to be checked any time the two addresses are equal, and theship_addressis a new record. I think this was probably the original intention of checkingempty?(only new records can be empty because of Address's validations).Test changes aren't required, but make more specific assertions about our app's behaviour.