Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3.2] Do not require 'mail' #4792

Merged
merged 1 commit into from
Dec 20, 2022
Merged

[v3.2] Do not require 'mail' #4792

merged 1 commit into from
Dec 20, 2022

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from master to v3.2:

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Do not require 'mail'
6795597 
This was added a long time ago and is actually not necessary
anymore. If a shop depends on mail then through actionmailer.

Refs #4734

(cherry picked from commit 4ff8593)
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Merged
3 tasks
@waiting-for-dev waiting-for-dev changed the title [v3.2] Merge pull request #4740 from tvdeyen/remove-mail-require [v3.2] Do not require 'mail' Dec 20, 2022
@waiting-for-dev waiting-for-dev merged commit 938ff3c into v3.2 Dec 20, 2022
@waiting-for-dev waiting-for-dev deleted the backport/v3.2/pr-4740 branch December 20, 2022 17:12
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@tvdeyen tvdeyen

Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennyadsl @tvdeyen @waiting-for-dev