Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPStan check #336

Closed
wants to merge 3 commits into from
Closed

Add PHPStan check #336

wants to merge 3 commits into from

Conversation

franmomu
Copy link
Member

No description provided.

phansys
phansys requested changes Dec 12, 2019
View reviewed changes
OskarStark
OskarStark previously approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

.github/workflows/qa.yml
steps:
- uses: actions/checkout@master
- name: PHPStan
uses: "docker://oskarstark/phpstan-ga"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0.12.2 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason, why we shouldn't use the latest version? We're doing the same for every other QA tool (php-cs-fixer, phpunit, ...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok in this case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the PHP extension mongodb? can I do something?

core23
core23 previously approved these changes Dec 12, 2019
View reviewed changes
@franmomu franmomu dismissed stale reviews from core23 and OskarStark via 1eb9075 December 12, 2019 08:04
@franmomu franmomu force-pushed the fix_phpstorm branch 2 times, most recently from 1eb9075 to 2fbcbe2 Compare December 12, 2019 08:13
phansys
phansys requested changes Dec 12, 2019
View reviewed changes
@SonataCI
Copy link
Collaborator

SonataCI commented Feb 1, 2020

Could you please rebase your PR and fix merge conflicts?

@greg0ire greg0ire mentioned this pull request Apr 13, 2020
Merged
@greg0ire
Copy link
Contributor

@franmomu can you please extract your 2 first commits into a separate PR? I feel that the issue you have will not be easy to fix… a solution could be to run Composer with --ignore-platform-reqs, or to install the mongodb extension on @OskarStark 's Docker image, but both solutions sound like they would have unwanted consequences (installing packages that are not compatible with the targeted version of php, or ending up with an image with many, many, hopefully compatible extensions)

@franmomu
Copy link
Member Author

@franmomu can you please extract your 2 first commits into a separate PR? I feel that the issue you have will not be easy to fix… a solution could be to run Composer with --ignore-platform-reqs, or to install the mongodb extension on @OskarStark 's Docker image, but both solutions sound like they would have unwanted consequences (installing packages that are not compatible with the targeted version of php, or ending up with an image with many, many, hopefully compatible extensions)

Sure! I forgot about this one, I remember to check this and try to see a way to enable extension, but I didn't find an easy way.

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@greg0ire
Copy link
Contributor

@franmomu another option might be using stubs: doctrine/dbal#3951 (comment)

@franmomu
Copy link
Member Author

@franmomu another option might be using stubs: doctrine/dbal#3951 (comment)

I've just tried, but the problem is that composer install fails on install 😞

@greg0ire
Copy link
Contributor

Ah that's right, I forgot. I think it should be combined with --ignore-platform-reqs, which will imply contributing something to the phpstan-ga repo

@franmomu
Copy link
Member Author

I'll make a PR soon like the one for the dev dependencies

@franmomu franmomu mentioned this pull request Aug 1, 2020
Merged
@franmomu franmomu deleted the fix_phpstorm branch August 1, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@phansys phansys phansys requested changes

@core23 core23 core23 left review comments

Assignees
No one assigned
Labels
pedantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@franmomu @SonataCI @greg0ire @OskarStark @phansys @core23