-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spytest keysight container #3176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Mar 19, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps. Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch. If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds. Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
this adds docker definition file for a container that will be able to run spytest with keysight tgen. very helpful to avoid having to build the environment each time by hand, just build the container and enjoy dockerfile definition * few small fixes for discovery of libraries paths when installed in the default location What is the motivation for this PR? replicating the setup and having to manually build it created extra work, having a container that can run spytest will get anyone up and running much faster How did you do it? docker file definition libs and utils are instaled in docker, spytest files are mounted at runtime How did you verify/test it? used Keysight IxNetwork 9.10 and latest spytest from master on Keysight Novus platform. Any platform specific information? had to use ubuntu18 with python 2.7 , a container with ubuntu 20 and python 3 is in the works but requires more fixes for py3 compatibility. Documentation added a readme that will walk you through the steps needed to build the container and to run it. references the spytest docs also for the spytest side of configuration steps. Co-authored-by: Mircea Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
this adds docker definition file for a container that will be able to run spytest with keysight tgen.
very helpful to avoid having to build the environment each time by hand,
just build the container and enjoy
dockerfile definition
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
replicating the setup and having to manually build it created extra work, having a container that can run spytest will get anyone up and running much faster
How did you do it?
docker file definition
libs and utils are instaled in docker, spytest files are mounted at runtime
How did you verify/test it?
used Keysight IxNetwork 9.10 and latest spytest from master on Keysight Novus platform.
Any platform specific information?
had to use ubuntu18 with python 2.7 , a container with ubuntu 20 and python 3 is in the works but requires more fixes for py3 compatibility.
Supported testbed topology if it's a new test case?
Documentation
added a readme that will walk you through the steps needed to build the container and to run it.
references the spytest docs also for the spytest side of configuration steps.