[fib] Fix incorrect prefix/nh list generation for single_asic device #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for the investigation and fix! |
wangxin
approved these changes
May 6, 2021
@wangxin Thank you! |
bingwang-ms
pushed a commit
to bingwang-ms/sonic-mgmt
that referenced
this pull request
Aug 18, 2021
We are migrating from Jenkins to azure pipeline. This PR added azure pipeline yaml files and dependent template files for nightly tests. Pipeline yaml files only added for 3 testbeds yet. The pipelines were originally added to branch azp-test of repo https://dev.azure.com/mssonic/internal/_git/sonic-mgmt-int. They have been tested on Azure DevOps. Now we formally add these pipelines to the Networking-acs-sonic-mgmt repo. Currently the internal branch of Networking-acs-sonic-mgmt is synched to same internal branch of the sonic-mgmt-int repo. After this PR is merged, we need to update configuration of the created pipelines to formally use these files from the internal branch. If the pipelines work fine with yaml files from internal branch, we will create more pipeline files based on current templates for rest of the nightly testbeds. Related work items: sonic-net#3021, sonic-net#3073, sonic-net#3135, sonic-net#3153, sonic-net#3162, sonic-net#3176, sonic-net#3238, sonic-net#3241, sonic-net#3346, sonic-net#3352, sonic-net#3378, sonic-net#3389, sonic-net#3395, sonic-net#3397, sonic-net#3398, sonic-net#3407, sonic-net#3410, sonic-net#3411, sonic-net#3412, sonic-net#3413, sonic-net#3414, sonic-net#3415, sonic-net#3434, sonic-net#3437, sonic-net#3445, sonic-net#3446, sonic-net#3447, #9740131, #9821349
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…-net#3352) What is the motivation for this PR? PR 3214 introduced multi-asic support for fib test. test_basic_fib fails on single-asic devices with the following error: "AssertionError: Received expected packet on port 13 for device 0, but it should have arrived on one of these ports: [28, 29, 30, 31]. This occurs due to prefixes for directly connected subnets not being added to fib_info_file. E.g. we have following entry on DUT: "ROUTE_TABLE:192.168.0.0/21": { "expireat": 1618578926.178756, "ttl": -0.001, "type": "hash", "value": { "ifname": "Vlan1000", "nexthop": "0.0.0.0" } } Previously, we added entry for 192.168.0.0/21 to fib_info with nexthop '[]' and skipped this range later during the test. Now this entry is skipped from the start and not added to fib_info. This results in IP range for subnet 192.168.0.0/21 (or any other directly connected subnet) being considered a part of IP range for previous subnet: Expected IP range: 169.255.0.0 - 192.167.255.255 192.168.0.0 - 192.168.7.255 192.168.8.0 - 192.168.8.127 Actual IP range: 169.255.0.0 - 192.168.7.255 192.168.8.0 - 192.168.8.127 How did you do it? For single-asic devices, skipped prefixes are now added to fib_info file with nexthop '[]'. How did you verify/test it? Run test_basic_fib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes test_basic_fib failing due to incorrect fib_info generation on single_asic devices.
Type of change
Approach
What is the motivation for this PR?
PR 3214 introduced multi-asic support for fib test.
test_basic_fib fails on single-asic devices with the following error:
"AssertionError: Received expected packet on port 13 for device 0, but it should have arrived on one of these ports: [28, 29, 30, 31].This occurs due to prefixes for directly connected subnets not being added to fib_info_file.
E.g. we have following entry on DUT:
Previously, we added entry for
192.168.0.0/21to fib_info with nexthop '[]' and skipped this range later during the test.Now this entry is skipped from the start and not added to fib_info.
This results in IP range for subnet 192.168.0.0/21 (or any other directly connected subnet) being considered a part of IP range for previous subnet:
Expected IP range:
Actual IP range:
How did you do it?
For single-asic devices, skipped prefixes are now added to fib_info file with nexthop '[]'.
How did you verify/test it?
Run test_basic_fib
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation