OrchAgent add more logging #12

kcudnik · 2016-04-08T01:12:18Z

No description provided.

stcheng · 2016-04-13T23:59:00Z

I think this will be too verbose.
I'll add proper logs in side functions.

lguohan · 2016-04-14T07:44:22Z

debug log, i'm ok with that. In production, should only turn on info or notice level.

kcudnik · 2016-04-14T18:01:31Z

I can change it to INFO, since i just needed this for debug.

stcheng · 2016-04-14T18:32:32Z

I've reviewed the code change and I think not all the places here need to add SWSS_LOG_ENTER();.
I've leaved some comments. Some functions will crucial functionalities will need this.

stcheng · 2016-04-14T18:33:06Z

orchagent/main.cpp

@@ -40,6 +40,8 @@ const char *test_profile_get_value (
    _In_ sai_switch_profile_id_t profile_id,
    _In_ const char *variable)
 {
+    SWSS_LOG_ENTER();
+


short function. no need to add this.

it's better to know which values sai library is reading.

kcudnik · 2016-04-15T18:37:29Z

It will be very helpful when debugging, i can change default level to INFO if you want

hrachya-m · 2016-04-15T22:50:55Z

There are enter/exit logs inside our SAI implementation. They are were helpful for debug and diagnostics.

stcheng · 2016-04-19T01:32:02Z

ack

* Adding markdown format architecture doc

We wanted the queue stats to be enabled with high interval, also this is to fix below errors in snmp agent: May 16 07:44:14.812487 lnos-x1-a-asw03 ERR snmp-subagent [sonic_ax_impl] ERROR: No queue stat counters found in the Counter DB. SyncD database is incoherent. May 16 07:44:14.812981 lnos-x1-a-asw03 ERR snmp-subagent [ax_interface] ERROR: MIBUpdater.start() caught an unexpected exception during update_data()sonic-net#12 Traceback (most recent call last):sonic-net#12 File "/usr/local/lib/python3.6/dist-packages/ax_interface/mib.py", line 40, in start#012 self.reinit_data()sonic-net#12 File "/usr/local/lib/python3.6/dist-packages/sonic_ax_impl/mibs/vendor/cisco/ciscoSwitchQosMIB.py", line 79, in reinit_data#012 mibs.init_sync_d_queue_tables(self.db_conn)sonic-net#12 File "/usr/local/lib/python3.6/dist-packages/sonic_ax_impl/mibs/__init__.py", line 220, in init_sync_d_queue_tables#012 raise RuntimeError('The queue_stat_map is not defined')sonic-net#12 RuntimeError: The queue_stat_map is not defined

[sonic_cli]: Fix bash completion for 'show' command

…onic-net#1215) route_check.py will report an ERROR in syslog if route mismatch is found, which is out control of monit config file. This commit add an option (-s) to control whether error will be reported in syslog. **- How to verify it** The update is verified on Arista-7260. 1. Add a static route whose nexthop is not reachable. ``` ip route add 1.1.1.1 via 192.168.1.101 ``` 2. Run ```route_check.py```, and error msg is only printed on stdout. Nothing is writen to syslog 3. Run ```route_check.py -s```. and error msg is writen to both stdout and syslog 4. Wait for 15 minutes, and confirm that monit will report the error ``` Nov 4 09:30:36.917367 str-7260cx3-acs-2 ERR monit[631]: 'routeCheck' status failed (255) -- results: { {sonic-net#12 "missed_ROUTE_TABLE_routes": [sonic-net#12 "1.1.1.1/32"sonic-net#12 ]sonic-net#12} }sonic-net#12 Failed. Look at reported mismatches above ``` Signed-off-by: bingwang <[email protected]>

This commit fix the exception thrown by struct.pack when attempting to pack a unicode string. The script ```fast-reboot-dump.py``` will throw an exception in python3 because ```struct.pack``` requires ```bytes``` for ```s```. ``` Traceback: Traceback (most recent call last): sonic-net#12 File "/usr/local/bin/fast-reboot-dump.py", line 299, in <module> sonic-net#12 res = main() sonic-net#12 File "/usr/local/bin/fast-reboot-dump.py", line 292, in main sonic-net#12 send_garp_nd(neighbor_entries, map_mac_ip_per_vlan) sonic-net#12 File "/usr/local/bin/fast-reboot-dump.py", line 221, in send_garp_nd sonic-net#12 src_ip_addrs = {vlan_name:get_iface_ip_addr(vlan_name) for vlan_name,_,_ in neighbor_entries} sonic-net#12 File "/usr/local/bin/fast-reboot-dump.py", line 221, in <dictcomp> sonic-net#12 src_ip_addrs = {vlan_name:get_iface_ip_addr(vlan_name) for vlan_name,_,_ in neighbor_entries} sonic-net#12 File "/usr/local/bin/fast-reboot-dump.py", line 195, in get_iface_ip_addr sonic-net#12 return get_if(iff, SIOCGIFADDR)[20:24] sonic-net#12 File "/usr/local/bin/fast-reboot-dump.py", line 185, in get_if sonic-net#12 ifreq = ioctl(s, cmd, struct.pack("16s16x",iff)) sonic-net#12 struct.error: argument for 's' must be a bytes object ``` Signed-off-by: bingwang <[email protected]>

* Add port counters collector thread * Use VID for port ID counter statistics * Get only supported counters, allow tune interval

Signed-off-by: Guohan Lu <[email protected]>

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

…tries in gRouteBulker  **What I did** Avoid removing a VRF routing table when there are pending creation entries in gRouteBulker 1. Remove a VRF routing table when a routing entry is removed only if there is no pending creation entry in gRouteBulker 2. Avoid uninitialized value SAI IP address/prefix structure **Why I did it** Fix issue: out of range exception can be thrown in `addRoutePost` due to non exist VRF ``` (gdb) bt #0 0x00007f5791aedebc in ?? () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#1 0x00007f5791a9efb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#2 0x00007f5791a89472 in abort () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#3 0x00007f5791de0919 in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#4 0x00007f5791debe1a in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#5 0x00007f5791debe85 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#6 0x00007f5791dec0d8 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#7 0x00007f5791de3240 in std::__throw_out_of_range(char const*) () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#8 0x00005594e856d956 in std::map<unsigned long, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > > > > >::at (this=<optimized out>, __k=<optimized out>) at /usr/include/c++/12/bits/stl_map.h:551 sonic-net#9 0x00005594e8564beb in RouteOrch::addRoutePost (this=this@entry=0x5594ea13e080, ctx=..., nextHops=...) at ./orchagent/routeorch.cpp:2145 sonic-net#10 0x00005594e856b0b2 in RouteOrch::doTask (this=0x5594ea13e080, consumer=...) at ./orchagent/routeorch.cpp:1021 sonic-net#11 0x00005594e85282d2 in Orch::doTask (this=0x5594ea13e080) at ./orchagent/orch.cpp:553 sonic-net#12 0x00005594e851909a in OrchDaemon::start (this=this@entry=0x5594ea0a0950) at ./orchagent/orchdaemon.cpp:895 sonic-net#13 0x00005594e8485632 in main (argc=<optimized out>, argv=<optimized out>) at ./orchagent/main.cpp:818 ``` **How I verified it** Unit (mock) test **Details if related** Originally, it cleaned up a VRF routing table whenever a prefix of the VRF was removed if 1. there was no routing entry in the VRF routing table and 2. the prefix was not pending creation in gRouteBulker The motivation is to remove a VRF routing table if there is no routing entry in the VRF and no routing entry pending creation for that VRF. However, condition 2 does not guarantee that. The ideal way of the 2nd condition is to check pending creation entries of a certain VRF, which we can not do. So, we are using strict conditions here as the following: 1. there is no routing entry in the VRF routing table and 2. there is no pending creating routing entry in gRouteBulker regardless of which VRF it belongs to

…tries in gRouteBulker (#3493)  **What I did** Avoid removing a VRF routing table when there are pending creation entries in gRouteBulker 1. Remove a VRF routing table when a routing entry is removed only if there is no pending creation entry in gRouteBulker 2. Avoid uninitialized value SAI IP address/prefix structure **Why I did it** Fix issue: out of range exception can be thrown in `addRoutePost` due to non exist VRF ``` (gdb) bt #0 0x00007f5791aedebc in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007f5791a9efb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007f5791a89472 in abort () from /lib/x86_64-linux-gnu/libc.so.6 #3 0x00007f5791de0919 in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 #4 0x00007f5791debe1a in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 #5 0x00007f5791debe85 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6 #6 0x00007f5791dec0d8 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 #7 0x00007f5791de3240 in std::__throw_out_of_range(char const*) () from /lib/x86_64-linux-gnu/libstdc++.so.6 #8 0x00005594e856d956 in std::map<unsigned long, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > > > > >::at (this=<optimized out>, __k=<optimized out>) at /usr/include/c++/12/bits/stl_map.h:551 #9 0x00005594e8564beb in RouteOrch::addRoutePost (this=this@entry=0x5594ea13e080, ctx=..., nextHops=...) at ./orchagent/routeorch.cpp:2145 #10 0x00005594e856b0b2 in RouteOrch::doTask (this=0x5594ea13e080, consumer=...) at ./orchagent/routeorch.cpp:1021 #11 0x00005594e85282d2 in Orch::doTask (this=0x5594ea13e080) at ./orchagent/orch.cpp:553 #12 0x00005594e851909a in OrchDaemon::start (this=this@entry=0x5594ea0a0950) at ./orchagent/orchdaemon.cpp:895 #13 0x00005594e8485632 in main (argc=<optimized out>, argv=<optimized out>) at ./orchagent/main.cpp:818 ``` **How I verified it** Unit (mock) test **Details if related** Originally, it cleaned up a VRF routing table whenever a prefix of the VRF was removed if 1. there was no routing entry in the VRF routing table and 2. the prefix was not pending creation in gRouteBulker The motivation is to remove a VRF routing table if there is no routing entry in the VRF and no routing entry pending creation for that VRF. However, condition 2 does not guarantee that. The ideal way of the 2nd condition is to check pending creation entries of a certain VRF, which we can not do. So, we are using strict conditions here as the following: 1. there is no routing entry in the VRF routing table and 2. there is no pending creating routing entry in gRouteBulker regardless of which VRF it belongs to

OrchAgent add more logging

1371693

stcheng reviewed Apr 14, 2016
View reviewed changes

Change log level to INFO

59c9e34

stcheng closed this Apr 19, 2016

vharish02 pushed a commit to vharish02/sonic-swss that referenced this pull request Aug 6, 2018

Creating markdown format architecture doc (sonic-net#12)

abd2baf

* Adding markdown format architecture doc

ishidawataru pushed a commit to ishidawataru/sonic-swss that referenced this pull request Aug 29, 2018

[configdb] Support hierarchical keys (sonic-net#12)

7f8e7c5

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Nov 23, 2019

We should increment the increment when we continue (sonic-net#12)

53cedef

garigipati mentioned this pull request May 24, 2020

Applying the same Vnet's twice causes orchagent crash #1298

Closed

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022

[sonic_cli]: Fix bash completion for 'show' command (sonic-net#12)

ce84e28

[sonic_cli]: Fix bash completion for 'show' command

lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023

add detailed comments for get_transceiver_change_event (sonic-net#12)

5d32cbb

Signed-off-by: Guohan Lu <[email protected]>

anilkpan mentioned this pull request Aug 19, 2024

TD4 - swss not coming up with latest code #3259

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OrchAgent add more logging #12

OrchAgent add more logging #12

kcudnik commented Apr 8, 2016

stcheng commented Apr 13, 2016

lguohan commented Apr 14, 2016

kcudnik commented Apr 14, 2016

stcheng commented Apr 14, 2016 •

edited

Loading

stcheng Apr 14, 2016

lguohan Apr 18, 2016

kcudnik commented Apr 15, 2016

hrachya-m commented Apr 15, 2016

stcheng commented Apr 19, 2016

OrchAgent add more logging #12

OrchAgent add more logging #12

Conversation

kcudnik commented Apr 8, 2016

stcheng commented Apr 13, 2016

lguohan commented Apr 14, 2016

kcudnik commented Apr 14, 2016

stcheng commented Apr 14, 2016 • edited Loading

stcheng Apr 14, 2016

Choose a reason for hiding this comment

lguohan Apr 18, 2016

Choose a reason for hiding this comment

kcudnik commented Apr 15, 2016

hrachya-m commented Apr 15, 2016

stcheng commented Apr 19, 2016

stcheng commented Apr 14, 2016 •

edited

Loading