README.md: Initial install instructions, updated naming (sonic-*) #2

johnarnold · 2016-03-11T01:49:13Z

Signed-Off-By: John Arnold <[email protected]

Signed-off-by: John Arnold <[email protected]>

Signed-off-by: John Arnold <[email protected]

Signed-off-by: John Arnold <[email protected]>

stcheng · 2016-03-11T21:43:05Z

README.md

-
-### This software repository must be treated as private and is only shared under NDA terms with Microsoft until publicly released.
+[![Build Status](https://sonic-jenkins.westus.cloudapp.azure.com/buildStatus/icon?job=sonic-swss-build)](https://sonic-jenkins.westus.cloudapp.azure.com/job/sonic-swss-build)
+# Sonic - Switch State Service - SwSS


Sonic -> SONiC

Signed-off-by: John Arnold <[email protected]>

johnarnold · 2016-03-15T19:53:10Z

Updated SONiC spelling and fixed the URL.

stcheng · 2016-03-15T20:44:21Z

thanks.

* Add neighbor table warmrestart test cases * Change the interface to be used for neighbor table to avoid conflict * Add syslog and sairedis checks for neighbor sync

* Fix the stack-overflow issue in AclOrch::getTableById() In case the table_id and m_mirrorTableId/m_mirrorTableId are empty The function would be called recursively without ending. ``` If we have some rule that does not have table defined, it will trigger this issue. (gdb) bt #0 0x00007f77ac5af3a9 in swss::Logger::write (this=0x7f77ac801ec0 <swss::Logger::getInstance()::m_logger>, prio=swss::Logger::SWSS_DEBUG, fmt=0x7f77ac5f1690 ":> %s: enter") at logger.cpp:209 #1 0x00000000004a5792 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2617 #2 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #3 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 ... #20944 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #20945 0x00000000004ad3ce in AclOrch::doAclRuleTask (this=this@entry=0x1c722a0, consumer=...) at aclorch.cpp:2437 #20946 0x00000000004b04cd in AclOrch::doTask (this=0x1c722a0, consumer=...) at aclorch.cpp:2141 #20947 0x00000000004231b2 in Orch::doTask (this=0x1c722a0) at orch.cpp:369 #20948 0x000000000041c4e9 in OrchDaemon::start (this=this@entry=0x1c19960) at orchdaemon.cpp:376 #20949 0x0000000000409ffc in main (argc=<optimized out>, argv=0x7ffe2e392d68) at main.cpp:295 (gdb) p table_id $1 = "" (gdb) p m_mirrorTableId $2 = "" (gdb) p m_mirrorV6TableId $3 = "" ``` Signed-off-by: Zhenggen Xu <[email protected]>

Copp #2 changes Copp test changes Copp changes cleanup Cosmetic change#1 Cosmetic changes #2 NAT fix

Copp #2 changes Copp test changes Copp changes cleanup Cosmetic change#1 Cosmetic changes #2 NAT fix Fixing nat case

* [cbf] Added initial CBF support (#2) * Added CBF NHG support to NhgOrch * Added NhgMapOrch to handle DSCP_TO_FC and EXP_TO_FC tables * Added UT for the new NhgOrch function and NhgMapOrch Support sonic-net/SONiC#796 Co-authored-by: Alexandru Banu <[email protected]>

* change package name to sonic-utilities

Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 #2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 #2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <[email protected]>

Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) sonic-net#1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 sonic-net#2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 sonic-net#3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) sonic-net#1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 sonic-net#2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 sonic-net#3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <[email protected]>

Updated swss with latest from master temp check in review feedback Commented out test for chassis fix for compilation issue Fixed test failure feedback comments fix for processQ fix for processQ fix for processQ mock test update test_vlan.py fix skipping failing test for virtual chassis disable test_PortAutoNegWarm test minor fix disabling virtual chassis tests for now temp check in unskip failing test unkipped sonic-net#2 test fix minor errors temporarily disable test as PR sonic-net#2541 is having the fix

Signed-off-by: chenhu <[email protected]>

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

…tries in gRouteBulker  **What I did** Avoid removing a VRF routing table when there are pending creation entries in gRouteBulker 1. Remove a VRF routing table when a routing entry is removed only if there is no pending creation entry in gRouteBulker 2. Avoid uninitialized value SAI IP address/prefix structure **Why I did it** Fix issue: out of range exception can be thrown in `addRoutePost` due to non exist VRF ``` (gdb) bt #0 0x00007f5791aedebc in ?? () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#1 0x00007f5791a9efb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#2 0x00007f5791a89472 in abort () from /lib/x86_64-linux-gnu/libc.so.6 sonic-net#3 0x00007f5791de0919 in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#4 0x00007f5791debe1a in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#5 0x00007f5791debe85 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#6 0x00007f5791dec0d8 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#7 0x00007f5791de3240 in std::__throw_out_of_range(char const*) () from /lib/x86_64-linux-gnu/libstdc++.so.6 sonic-net#8 0x00005594e856d956 in std::map<unsigned long, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > > > > >::at (this=<optimized out>, __k=<optimized out>) at /usr/include/c++/12/bits/stl_map.h:551 sonic-net#9 0x00005594e8564beb in RouteOrch::addRoutePost (this=this@entry=0x5594ea13e080, ctx=..., nextHops=...) at ./orchagent/routeorch.cpp:2145 sonic-net#10 0x00005594e856b0b2 in RouteOrch::doTask (this=0x5594ea13e080, consumer=...) at ./orchagent/routeorch.cpp:1021 sonic-net#11 0x00005594e85282d2 in Orch::doTask (this=0x5594ea13e080) at ./orchagent/orch.cpp:553 sonic-net#12 0x00005594e851909a in OrchDaemon::start (this=this@entry=0x5594ea0a0950) at ./orchagent/orchdaemon.cpp:895 sonic-net#13 0x00005594e8485632 in main (argc=<optimized out>, argv=<optimized out>) at ./orchagent/main.cpp:818 ``` **How I verified it** Unit (mock) test **Details if related** Originally, it cleaned up a VRF routing table whenever a prefix of the VRF was removed if 1. there was no routing entry in the VRF routing table and 2. the prefix was not pending creation in gRouteBulker The motivation is to remove a VRF routing table if there is no routing entry in the VRF and no routing entry pending creation for that VRF. However, condition 2 does not guarantee that. The ideal way of the 2nd condition is to check pending creation entries of a certain VRF, which we can not do. So, we are using strict conditions here as the following: 1. there is no routing entry in the VRF routing table and 2. there is no pending creating routing entry in gRouteBulker regardless of which VRF it belongs to

…tries in gRouteBulker (#3493)  **What I did** Avoid removing a VRF routing table when there are pending creation entries in gRouteBulker 1. Remove a VRF routing table when a routing entry is removed only if there is no pending creation entry in gRouteBulker 2. Avoid uninitialized value SAI IP address/prefix structure **Why I did it** Fix issue: out of range exception can be thrown in `addRoutePost` due to non exist VRF ``` (gdb) bt #0 0x00007f5791aedebc in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007f5791a9efb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007f5791a89472 in abort () from /lib/x86_64-linux-gnu/libc.so.6 #3 0x00007f5791de0919 in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 #4 0x00007f5791debe1a in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6 #5 0x00007f5791debe85 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6 #6 0x00007f5791dec0d8 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 #7 0x00007f5791de3240 in std::__throw_out_of_range(char const*) () from /lib/x86_64-linux-gnu/libstdc++.so.6 #8 0x00005594e856d956 in std::map<unsigned long, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::map<swss::IpPrefix, RouteNhg, std::less<swss::IpPrefix>, std::allocator<std::pair<swss::IpPrefix const, RouteNhg> > > > > >::at (this=<optimized out>, __k=<optimized out>) at /usr/include/c++/12/bits/stl_map.h:551 #9 0x00005594e8564beb in RouteOrch::addRoutePost (this=this@entry=0x5594ea13e080, ctx=..., nextHops=...) at ./orchagent/routeorch.cpp:2145 #10 0x00005594e856b0b2 in RouteOrch::doTask (this=0x5594ea13e080, consumer=...) at ./orchagent/routeorch.cpp:1021 #11 0x00005594e85282d2 in Orch::doTask (this=0x5594ea13e080) at ./orchagent/orch.cpp:553 #12 0x00005594e851909a in OrchDaemon::start (this=this@entry=0x5594ea0a0950) at ./orchagent/orchdaemon.cpp:895 #13 0x00005594e8485632 in main (argc=<optimized out>, argv=<optimized out>) at ./orchagent/main.cpp:818 ``` **How I verified it** Unit (mock) test **Details if related** Originally, it cleaned up a VRF routing table whenever a prefix of the VRF was removed if 1. there was no routing entry in the VRF routing table and 2. the prefix was not pending creation in gRouteBulker The motivation is to remove a VRF routing table if there is no routing entry in the VRF and no routing entry pending creation for that VRF. However, condition 2 does not guarantee that. The ideal way of the 2nd condition is to check pending creation entries of a certain VRF, which we can not do. So, we are using strict conditions here as the following: 1. there is no routing entry in the VRF routing table and 2. there is no pending creating routing entry in gRouteBulker regardless of which VRF it belongs to

Darren Loher and others added 8 commits March 9, 2016 16:28

doc: Adding documentations

3c73b30

arch doc moved to sonic repo

66dd01d

adding schema doc

7049c67

README.md: Update install steps and contacts

6ae0d26

Signed-off-by: John Arnold <[email protected]>

README.md: Update build status link

f67b613

Signed-off-by: John Arnold <[email protected]>

README.md: Update naming and remove NDA

b879572

Signed-off-by: John Arnold <[email protected]>

README.md: Add apt key and update git URL

3f6ed0e

Signed-off-by: John Arnold <[email protected]

README.md: reset contributing section

3595dec

Signed-off-by: John Arnold <[email protected]>

stcheng force-pushed the master branch from 7049c67 to 104a3df Compare March 11, 2016 21:39

stcheng reviewed Mar 11, 2016
View reviewed changes

README.md: Update SONiC spelling

462c3cf

Signed-off-by: John Arnold <[email protected]>

stcheng force-pushed the master branch from 24aa2f6 to 6293c3d Compare March 15, 2016 20:24

stcheng closed this Mar 15, 2016

lguohan mentioned this pull request Apr 14, 2017

#1 AclOrch::collectCountersThread (pAclOrch=0x1614da0) at aclorch.cpp:1279 #190

Closed

pavel-shirshov mentioned this pull request Apr 30, 2017

GPF in orchagent. ACL counters related code #201

Closed

jipanyang mentioned this pull request Oct 13, 2017

orchagent hangs at switchorch due to erase operation on map #347

Closed

dzhangalibaba mentioned this pull request Sep 5, 2018

sonic-swss : moving AISC_DB to this new DB instance #606

Closed

vemulabalaji mentioned this pull request Nov 21, 2018

syslog message with invalid subnetmask #701

Open

andriymoroz-mlnx mentioned this pull request Dec 6, 2018

If available, read port settings from Config DB first #723

Merged

stepanblyschak mentioned this pull request Oct 27, 2019

[portsorch] fix PortsOrch::allPortsReady() returns true when it should not #1103

Merged

skg-net mentioned this pull request Nov 27, 2019

Increase ip2me CIR/CBS for faster in-band file transfers #1000

Merged

vasant17 mentioned this pull request May 14, 2020

[DPB/VLAN] Add test VS cases and fix FDB flush issues #1242

Merged

garigipati mentioned this pull request May 22, 2020

Applying the same Vnet's twice causes orchagent crash #1298

Closed

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 26, 2020

Copp #2 changes

4f7cf7a

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 26, 2020

Cosmetic changes #2

e722fa1

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 27, 2020

Copp Changes

fb79ed1

Copp #2 changes Copp test changes Copp changes cleanup Cosmetic change#1 Cosmetic changes #2 NAT fix

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 27, 2020

Copp Changes

353becb

Copp #2 changes Copp test changes Copp changes cleanup Cosmetic change#1 Cosmetic changes #2 NAT fix Fixing nat case

rupesh-k mentioned this pull request Jul 2, 2020

Fix in script to avoid orchagent crash when port down followed by fdb… #1340

Merged

rajkumar38 mentioned this pull request Jul 29, 2020

[fdborch] Fixed Orchagent crash in FDB flush on port disable. #1369

Merged

vasant17 mentioned this pull request Nov 20, 2020

Flush ARP/neighbor entry on FDB flush when port L2-L3 #1506

Merged

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 9, 2021

Changes #2

6694900

raphaelt-nvidia mentioned this pull request Oct 14, 2021

Orchagent validates mirror session queue parameter against maximum value from SAI #1957

Merged

EdenGri referenced this pull request in EdenGri/sonic-swss Feb 28, 2022

change package name to sonic-utilities (#2)

a3f98cd

* change package name to sonic-utilities

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

vmittal-msft added a commit to vmittal-msft/sonic-swss that referenced this pull request Dec 8, 2022

unkipped sonic-net#2 test

e1d8ff0

jcaiMR mentioned this pull request Jan 30, 2023

[Workaround] EvpnRemoteVnip2pOrch warmboot check failure #2626

Merged

xumia mentioned this pull request Mar 2, 2023

Compile error in sonic-swss/orchagent/orchdaemon.cpp for 202205 branch #2682

Closed

lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023

[sonic-platform-common] add support for qsfp28 eeprom (sonic-net#2)

6289809

Signed-off-by: chenhu <[email protected]>

prgeor mentioned this pull request May 5, 2023

[ppi]: Implement port bulk comparison logic #2564

Merged

vmittal-msft added a commit to vmittal-msft/sonic-swss that referenced this pull request Nov 21, 2023

Fix for VS test case sonic-net#2

a21f803

vmittal-msft added a commit to vmittal-msft/sonic-swss that referenced this pull request Nov 22, 2023

Fix for VS test case sonic-net#2

dde0106

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

README.md: Initial install instructions, updated naming (sonic-*) #2

README.md: Initial install instructions, updated naming (sonic-*) #2

johnarnold commented Mar 11, 2016

stcheng Mar 11, 2016

johnarnold commented Mar 15, 2016

stcheng commented Mar 15, 2016

README.md: Initial install instructions, updated naming (sonic-*) #2

README.md: Initial install instructions, updated naming (sonic-*) #2

Conversation

johnarnold commented Mar 11, 2016

stcheng Mar 11, 2016

Choose a reason for hiding this comment

johnarnold commented Mar 15, 2016

stcheng commented Mar 15, 2016