Sous Chefs adoption and Chef 17 fixes #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
detjensrobert
added
the
Release: Major
Signed-off-by: Robert Detjens <[email protected]>
xorima
reviewed
Jul 18, 2021
Dokken does not support fiddling with SELinux, which this cookbook needs to do. Thus, use Vagrant testing instead locally and in CI. Signed-off-by: Robert Detjens <[email protected]>
|
Looks like we're running into chef/bento#1333 on fedora. It might be a good idea to at least remove it from Github CI until that gets resolved. |
TODO: renable once chef/bento#1333 is merged Signed-off-by: Robert Detjens <[email protected]>
detjensrobert
force-pushed
the
detjensrobert/adoption
branch
from
bb9ea25 to
8d9fde4
Compare
xorima
approved these changes
Jul 20, 2021
|
Would you like me to write Inspec tests as part of this PR? Currently there are no tests, just the converge. |
|
Lets do that in the another PR |
ramereth
approved these changes
Jul 21, 2021
|
Released as: 4.0.0 |
bmhughes
pushed a commit
that referenced
this pull request
Jul 27, 2021
* standardize files with sous-chefs/repo-management Signed-off-by: Robert Detjens <[email protected]> * cookstyle fixes Signed-off-by: Robert Detjens <[email protected]> * Update README Signed-off-by: Robert Detjens <[email protected]> * update test platforms Signed-off-by: Robert Detjens <[email protected]> * add changelog entry Signed-off-by: Robert Detjens <[email protected]> * fix CI workflow Signed-off-by: Robert Detjens <[email protected]> * Remove dokken testing Dokken does not support fiddling with SELinux, which this cookbook needs to do. Thus, use Vagrant testing instead locally and in CI. Signed-off-by: Robert Detjens <[email protected]> * Remove fedora from CI testing temporarily TODO: renable once chef/bento#1333 is merged Signed-off-by: Robert Detjens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fully adopts this cookbook into Sous Chefs, and enables unified_mode for Chef 17 compatibility.
As requested in #74 (comment).
Issues Resolved
Fixes #75
Check List