Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contraband category mega-issue #31047

Open
66 of 70 tasks
slarticodefast opened this issue Aug 15, 2024 · 43 comments
Open
66 of 70 tasks

Contraband category mega-issue #31047

slarticodefast opened this issue Aug 15, 2024 · 43 comments
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention.

Comments

@slarticodefast
Copy link
Member

slarticodefast commented Aug 15, 2024

Let's collect all of them here so we have a better overview. If you find an item that got the wrong contraband category write a comment and I will add it to the list.

  • Cat ears should be syndicate contra

  • Syndicate pAI should be syndicate contra

  • Chest rig should be syndicate contra

  • Surplus crates should be contraband

  • Binary translator key should be science restricted instead of syndicate contra

  • Laser guns should be all security restricted

  • Weapons that don't belong to Cybersun or Nanotrasen should be majorly restricted (such as the retro laser blaster, the RPG, or the minigun)

  • Briefcases should be stealthy again

  • Hypodart and Hypopen boxes should be syndicate contra

  • Syndicate implanters should be marked as syndicate contra

  • Rigged boxing gloves should be stealthy

  • Riot shields and such should be security restricted

  • Security radio should be security restricted

  • RCD should be engineering restricted

  • Security crates should be properly marked as security restricted.

  • All security gun safes should be marked as security restricted

  • Secglasses should be command/security restricted. This is subject to further discussion with the admins. In case Add Command Glasses #30447 gets merged they should be changed to be security only.

  • Door remotes should be all command restricted, the armory remote is security and command restricted

  • Pinpointers should be either command restricted or syndicate contraband

  • Medal case should be command restricted

  • Security jetpack should be security restricted

  • Hot potato should be marked as a syndicate item

  • Nuclear bomb should be marked as major contraband

  • Stamps should be either command restricted or security restricted

  • Ninja gear should be major contraband

  • Combat gloves should be security/engineering restricted

  • Syndie hand flag should be syndie contra

  • Syndicate codeword papers should be syndie contra

  • CentComm pen should not be syndicate contra

  • Practice laser rifles and disablers should not be security restricted

  • Energy dagger pens should only show as contra when toggled on

  • All giant ass sword type weapons should be upgraded from minor contra to major contra

  • fix(contraband): Make contraband work with chameleon items #30986

  • Bloodred magboots are engi-restricted instead of syndicate contra #30931

  • The advanced magboots should show as command restricted and have a grand theft label.

  • Grenades should be contraband

  • Encryption keys, in particular security, command and the master key should be contraband. The respective headsets are already marked as contraband

  • The fire axe (syndicate weapon) should be syndicate contraband.

  • The raid suit's helmet should be syndicate contraband instead of departmentally restricted.

  • Thief undetermined toolbox should be contraband

  • Thieving beacon should be contraband

  • Mercenary clothing, maybe sec restricted?

  • Lethal ammunition should be contraband

  • Grenades, Rockets, see explosives.yml should be contraband

  • Advanced circular saw should be contraband

  • Nukie Plushie should not be contraband

  • acolyte armor should be contraband

  • ClothingHeadHelmetERTLeader should not be syndicate contraband

  • Add Central Command contraband category

  • The ERT gas mask should be command/CentCom restricted.

  • Bladed Flatcap should not be contraband (stealth item)

  • Explorer gas mask should be cargo restricted

  • AKMS should be security restricted (found in Bagel armory)

  • The swat gas mask the HOS starts with should be security restricted, not cargo

  • The bone helmet should not be security restriced, but something else (I think?)

  • chitinous armor, bone armor and ironclad II armor should be marked as contraband/restricted

  • The communications console board should be command restricted or grand theft (check the other theft target machine boards as well)

  • ClothingOuterCoatHoSTrench should be command or security restricted (the same as ClothingOuterWinterHoS)

  • The x-ray cannon should be security restricted

  • Stinger grenades should be security restricted, not syndie contraband (they are in the sec vend)

  • Possibly botany plants and seed (e.g. death nettle, killer tomatos), although these can have some legitimate uses.

  • Add the option to restrict objects to certain jobs, not only departments, in particular:

  • The bandolier should be allowed for the bartender.

  • Allow armored vests and double barreled shotguns for bartenders

  • The sawn-off shotgun should be restricted to bartender/security

  • The roundstart headset for lawyers should not be considered contraband for them

  • Maybe make galoshes janitor restricted?

  • Tesla gun

  • pipe bombs and improvised bombs should be contraband

  • contraband system for reagents #33184

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 15, 2024
@slarticodefast slarticodefast removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 15, 2024
@Everturning
Copy link

Please make it so secglasses are SECURITY restricted, not command/security. Also we need some sort of difference between "highly illegal syndicate contraband" and stuff like the syndie flag, like "This is somewhat illegal syndicate contraband, but you should be fine to carry it around" and "This is central command restricted contraband!"

@slarticodefast
Copy link
Member Author

Please make it so secglasses are SECURITY restricted, not command/security.

This is currently being discussed with the admins. A possible solution could be the addition of the special command glasses, which only show the job icon, but not wanted status #30447

@JIPDawg
Copy link
Contributor

JIPDawg commented Aug 15, 2024

Please make it so secglasses are SECURITY restricted, not command/security.

This is currently being discussed with the admins. A possible solution could be the addition of the special command glasses, which only show the job icon, but not wanted status #30447

Would still need to make SecGlasses restricted right? What would be stopping Command from just ditching the command glasses and getting SecGlasses.

@slarticodefast
Copy link
Member Author

Would still need to make SecGlasses restricted right? What would be stopping Command from just ditching the command glasses and getting SecGlasses.

Yes, that would have to be added to that PR.

@Dutch-VanDerLinde
Copy link
Contributor

the fire axe has its own design and description so it isnt a stealth item

@TheDoctor1977
Copy link

The raid suit's helmet (not the actual suit) says it's departmentally restricted instead of syndicate contraband

@slarticodefast slarticodefast added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. labels Aug 16, 2024
@Savsj
Copy link

Savsj commented Aug 16, 2024

Merc gear should be sec restricted i belive its currently incorrectly parented as syndie gear

@UBlueberry
Copy link
Contributor

The CE's advanced magboots are listed as engineering restricted, not command restricted
Also they don't have the "This item is a highly valuable target for Syndicate agents!" tag

@supersayangoblin
Copy link

the acolyte armor should be listed as syndicate or minor contraband, because it is functional armor exclusive to emagging a vendor. there is no other way to get it other than emagging the pietyvendor

@Golinth
Copy link
Contributor

Golinth commented Aug 20, 2024

Nukie Plushie?

The Nukie Plushie can spawn in the cap's locker, it would be weird to include it as contraband imo

@slarticodefast
Copy link
Member Author

The Nukie Plushie can spawn in the cap's locker, it would be weird to include it as contraband imo

It currently is contraband. That's why I added it. I'll make it more clear

@TurboTrackerss14
Copy link
Contributor

parent: [ClothingHeadHatGreyFlatcap, BaseSyndicateContraband]

Bladed flatcap is an improvised weapon but is marked as syndicate contraband

@supersayangoblin
Copy link

parent: [ClothingHeadHatGreyFlatcap, BaseSyndicateContraband]

Bladed flatcap is an improvised weapon but is marked as syndicate contraband

it really SHOULDN'T be marked as contraband, as its a stealthy weapon (last time i checked)

@slarticodefast
Copy link
Member Author

it really SHOULDN'T be marked as contraband, as its a stealthy weapon (last time i checked)

Good point. You can still see the damage it does upon examination though, so it's still kinda obvious?

@supersayangoblin
Copy link

Good point. You can still see the damage it does upon examination though, so it's still kinda obvious?

you can see a hypopen's reagent counter on inspection, but that doesn't make it immediately obvious contraband. If the weapon has a line stating it's bladed in its description box, however, then its fair game (this is the part I'm not so sure of, because i forget the description)

@TurboTrackerss14
Copy link
Contributor

TurboTrackerss14 commented Aug 24, 2024

image
image

Probably should be restricted to cargo considering the armor? (considering its literally better than sec gasmask armor)

@slarticodefast
Copy link
Member Author

slarticodefast commented Aug 24, 2024

Probably should be restricted to cargo considering the armor? (considering its literally better than sec gasmask armor)

Do they have that round-start or is it salvage loot?

@EmoGarbage404
Copy link
Contributor

explorer masks are just roundstart stuff.

@Golinth
Copy link
Contributor

Golinth commented Aug 24, 2024

Probably should be restricted to cargo considering the armor? (considering its literally better than sec gasmask armor)

Do they have that round-start or is it salvage loot?

Round start salv. I don’t remember if you can get more, I don’t think so though. Maybe when finding a mining suit crate.

@TurboTrackerss14
Copy link
Contributor

image
ERT mask = contraband :trollface:

@UbaserB
Copy link
Member

UbaserB commented Aug 25, 2024

Bandolier is not allowed by the bartender

image

@lzk228
Copy link
Contributor

lzk228 commented Aug 27, 2024

cleanades marked as contraband

@Djungelskog2
Copy link

image
thinking about it... what if people get promoted?

image
It shouldnt because its a stealth item

image
Shouldnt it be department restricted? (Security, comes in bagel armoury)

image
I dont... why??? you can get it from the lottery and its not syndicate related in any way outside of it being accessible from the uplink, and its got no functional usage

@Djungelskog2
Copy link

I have also been told that it's contraband if it's "primarily obtained in the uplink" and I think cat ears are common enough from lotteries to be excluded from that

@CookieMasterT
Copy link
Contributor

The swat gasmask that Head of security starts with is marked as cargo restricted

@TurboTrackerss14
Copy link
Contributor

image

@Dragonjspider
Copy link

Salvage use normal magboots for their job and can get them out of their locker, but they're restricted to engineering so they appear to be contraband to salvagers

@themias
Copy link
Contributor

themias commented Sep 11, 2024

Some armors might need to be marked as contraband:

  • chitinous armor
  • bone armor
  • ironclad II armor.

@deltanedas
Copy link
Contributor

Salvage use normal magboots for their job and can get them out of their locker, but they're restricted to engineering so they appear to be contraband to salvagers

the eva room also has magboots i think, so it should just be removed or changed to say jobs with external access

@slarticodefast
Copy link
Member Author

I thought normal magboots being contra was fixed already?
grafik

@Dragonjspider
Copy link

I thought normal magboots being contra was fixed already?
grafik

It was yes... three days after I mentioned it... #30960 :trollface:

@Golinth
Copy link
Contributor

Golinth commented Sep 20, 2024

galoshes should be jani restricted. Ive seen officers justify using them because they "arent really contra"

@Golinth
Copy link
Contributor

Golinth commented Sep 23, 2024

x-ray cannons are not security restricted
image

@Golinth
Copy link
Contributor

Golinth commented Sep 25, 2024

The HoS’s trench coat is not security restricted

@Golinth
Copy link
Contributor

Golinth commented Oct 3, 2024

Omega soap should probably be contraband, it's syndie soap but better, and iirc was considered contraband before the inspect came along

@azloserbits
Copy link
Contributor

Please make it so secglasses are SECURITY restricted, not command/security.

This is currently being discussed with the admins. A possible solution could be the addition of the special command glasses, which only show the job icon, but not wanted status #30447

Administrative glasses would be AWESOME, the admin hud isn't flash immune.

@ArtisticRoomba
Copy link
Contributor

Administrative glasses would be AWESOME, the admin hud isn't flash immune.

we already have admin glasses and admin huds

@K-Dynamic
Copy link
Contributor

Dogi needs to be marked as Syndicate contraband, obtainable from emagged TheatreDrobe and has decent armor protection.

@slarticodefast
Copy link
Member Author

@Golinth I asked admins about the omega soap.
I think it is fine without being contraband.
grafik

@Kuutioo
Copy link

Kuutioo commented Dec 18, 2024

Tesla gun is also not marked as contraband.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention.
Projects
None yet
Development

No branches or pull requests