CorrectContraband levels on each type of magboots

[TyAshley]

About the PR

All magboots, even blood-reds, say they are engineering contraband. I corrected each type of magboots to reflect the appropriate contraband type. Advanced Magboots are Grand Theft Contraband, as they are a Syndie Objective. Blood Reds are Syndie Contraband. No other magboots are contraband.

Fixes #30931

Why / Balance

Show the correct contraband type to a user when examining an item.

Technical details

Added a ClothingShoesBootsMagBase that is the parent of all other magboot types, this has no contraband level. Modified each of the other magboot child entities to have the appropriate contraband level.

Media

Requirements

• I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Modified magboots.yml to have a new base/parent entity "ClothingShoesBootsMagBase." This has no contraband parent, and is the parent of all the other magboots types, which now have their own contraband parents set.

Changelog

🆑 Allen

• fix: Magboots and Science Magboots are no longer contraband. Advanced Magboots and Blood-Red Magboots now have appropriate contraband types (Grand Theft and Syndie Contraband respectively)

[Brandon-Huu]

This should be made abstract.
https://github.com/space-wizards/space-station-14/pull/30960/files#diff-561368ee69e714fc0d3399dcaacfe7bfebf482d25e0eae14380066d580e4bd0bR1-R36

[TyAshley]

This should be made abstract. https://github.com/space-wizards/space-station-14/pull/30960/files#diff-561368ee69e714fc0d3399dcaacfe7bfebf482d25e0eae14380066d580e4bd0bR1-R36

I have changed the base entity to be abstract

[EmoGarbage404]

do magboots even qualify as engineering contraband to begin with? They're available in quite a few other places like salv and general EVA?

[TyAshley]

If magboots are not supposed to be engineering contraband, that is something that can be changed easily. Currently, every type of magboots is listed as engineering contraband. The PR was to fix the egregious issues (namely, bloodreds not being syndicate contraband).

[Emisse]

only thing contraband should be blood-red magboots

[UbaserB]

You coming back to this?

[TyAshley]

I've been on vacation and will get back Tuesday and plan on doing it then (unless someone else gets to it first)

[UbaserB]

I've been in vacation an will get back Tuesday and plan on doing it then (unless someone else gets to it first)

There's a draft PR open for the bloodred magbots but not the rest so it seems fine to me to just wait for the most part

[TyAshley]

I've been in vacation an will get back Tuesday and plan on doing it then (unless someone else gets to it first)

There's a draft PR open for the bloodred magbots but not the rest so it seems fine to me to just wait for the most part

I removed engineering contraband from the regular Magboots. Now the only contraband magboots are the CE's Advanced Mag Boots (Grand Theft Contraband) and the Blood-Reds (Syndie Contraband).

it got fixed