Fix UninitializedSaveTest prototypes #16144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
commented
May 6, 2023
Comment on lines
38
to
-40
| private void OnCollide(EntityUid uid, LightningComponent component, ref StartCollideEvent args) | ||
| { | ||
| if (!TryComp<BeamComponent>(uid, out var lightningBeam) || !TryComp<BeamComponent>(lightningBeam.VirtualBeamController, out var beamController)) |
There was a problem hiding this comment.
I changed this function around while making ArcTarget nullable.
I'm not entirely sure what the function was meant to be doing, but AFAICT there was a chance it would enter an infinite loop if Arc failed to find a target? So now it no longer does a while loop, which might change some behaviour if it fails to find a target during the first attempt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15940 and re-adds a check for whether uninitialized entities are writing references to other entities while serializing.
Note that I haven't actually tested most of these changes in game, I just changed the prototypes until the test was happy, but AFAIK this shouldn't cause any issues seeing as the entities were being modified on spawn anyways.