Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix UninitializedSaveTest prototypes" #16169

Merged
merged 1 commit into from
May 6, 2023

Conversation

AJCM-git
Copy link
Member

@AJCM-git AJCM-git commented May 6, 2023

Reverts #16144

im 90% sure the lighting changes made the electricity anomaly try to delete already deleted entities and crash the server
image

@AJCM-git AJCM-git merged commit de1613f into master May 6, 2023
@AJCM-git AJCM-git deleted the revert-16144-fix-save-test branch May 6, 2023 14:50
ElectroJr added a commit to ElectroJr/space-station-14 that referenced this pull request May 6, 2023
@ElectroJr
Copy link
Member

im 90% sure the lighting changes made the electricity anomaly try to delete already deleted entities and crash the server

FWIW, just deleting already deleted components shouldn't cause the server to crash

keronshb pushed a commit that referenced this pull request May 6, 2023
* Revert "Revert "Fix UninitializedSaveTest prototypes" (#16169)"

This reverts commit de1613f.

* Invert if statement
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request May 25, 2023
…16169)" (space-wizards#16175)

* Revert "Revert "Fix UninitializedSaveTest prototypes" (space-wizards#16169)"

This reverts commit de1613f.

* Invert if statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants