Revert "Revert "Fix UninitializedSaveTest prototypes" (#16169)" #16175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroJr
commented
May 6, 2023
|
Hold off on merging, reviewing this |
keronshb
added
the
S: DO NOT MERGE
Content.Client_0u6MhfbjHt.mp4Tested, spammed lightning, nothing catastrophic. |
keronshb
added
S: Needs Review
|
This should be fine since lightning isn't going ham anymore. |
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
May 25, 2023
…16169)" (space-wizards#16175) * Revert "Revert "Fix UninitializedSaveTest prototypes" (space-wizards#16169)" This reverts commit de1613f. * Invert if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't actually managed to figure out how to reproduce the crash, but it might be fixed now?
It would be good if If someone could figure out how to actually reproduce it.