Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown shuttle changes #28723

Closed
wants to merge 12 commits into from
Closed

Unknown shuttle changes #28723

wants to merge 12 commits into from

Conversation

neutrino-laser
Copy link
Contributor

@neutrino-laser neutrino-laser commented Jun 8, 2024 •
edited
Loading

About the PR

Added minor refactoring to the following Unknown shuttle events:

Why / Balance

Addresses 3 of 4 issues brought up in #27972, but with less focus on redesign and more on balance.
The last issue, the clown shuttle having spiders, has been resolved by another PR.

Technical details

  • Renamed Syndie Disaster Victim to Syndicate Deserters. Adjusted description and rules to be some thing like a "neutral" antag.
    • Syndicate Deserters' only objective is to survive - how they do that is up to them (befriending crew, siding with traitors,
      going at it alone, etc.)
    • Prototype for Syndicate Deserter is now SyndicateFootsoliderGear to match their new role more closely.
  • Lost cargo shuttle tweaks
    • Replaced SalvageLootSpawner with CrateCargoGambling on lost cargo shuttle. Now cargo techs will not have
      guaranteed salvage weapons.
    • Replaced SalvageMaterialCrateSpawner with CrateFilledSpawner
  • Traveling chef shuttle tweaks
    • Replaced FoodMealSashimi with FoodMealEnchiladas. Traveling chef no longer has the ability to kill 2 people near-
      immediately by feeding them sashimi.
    • However, the raw carp is still there, meaning if the traveling chef can get some table salt, they can still make it. Just
      requires some interaction from the station crew.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None noticed.

Changelog

🆑

  • tweak: Syndie disaster victim event renamed to Syndicate deserters, a netural antag role.
  • tweak: Lost cargo shuttles no longer spawn salvage + cargo loot, only cargo.
  • tweak: Traveling chef now starts with enchiladas instead of sashimi.

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jun 8, 2024
@neutrino-laser neutrino-laser marked this pull request as draft June 8, 2024 16:48
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@UbaserB
Copy link
Member

UbaserB commented Sep 3, 2024

Are you coming back to this?

@neutrino-laser
Copy link
Contributor Author

@UbaserB Probably this weekend, life has been busy.

If I don't come back to this in two weeks, feel free to close it.

@github-actions github-actions bot added the Changes: Map Changes: Might require knowledge of mapping. label Sep 7, 2024
@neutrino-laser neutrino-laser force-pushed the unknown-shuttle-changes branch from 19cbcc2 to 66f3b78 Compare September 7, 2024 21:45
@neutrino-laser
Merge branch 'unknown-shuttle-changes' of https://github.com/neutrino…
aca5dca 
…-laser/space-station-14 into unknown-shuttle-changes
@neutrino-laser
ignore
d3026c1 
 Please enter the commit message for your changes. Lines starting
@neutrino-laser neutrino-laser reopened this Sep 7, 2024
@neutrino-laser
Copy link
Contributor Author

fat fingered the close button lol

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 7, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@SlamBamActionman
Copy link
Member

Hello! Are you still working on this PR, and/or is it still relevant to the state of the game today? I know there's been some changes to shuttles and considering the PR is marked as draft I want to make sure whether it's active or not still.

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@SlamBamActionman SlamBamActionman added P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it S: Stale Status: Stale with no activity, and may be closed after a week if there is no new activity. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
@slarticodefast
Copy link
Member

Closing this as derelict and the shuttles have been overhauled anyways.
If you want the PR reopened, leave a comment.

@slarticodefast slarticodefast added S: Derelict Status: Abandoned, but may contain something that can be salvaged. and removed S: Stale Status: Stale with no activity, and may be closed after a week if there is no new activity. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Derelict Status: Abandoned, but may contain something that can be salvaged. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neutrino-laser @UbaserB @SlamBamActionman @slarticodefast