Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snails #30765

Merged
merged 19 commits into from
Sep 3, 2024
Merged

Add Snails #30765

merged 19 commits into from
Sep 3, 2024

Conversation

IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Aug 8, 2024 •
edited
Loading

About the PR

image
(lmao, ignore the tiny dots, those are itybity chairs I thought were imperceptible that the snails are sitting on.)

Snail varieties:
Snail
Snoth
Snail but with a jetpack and goes fast
Snail that cannot die and kills you if it touches you

Why / Balance

Snail

Technical details

I made MobState have a MapInitEvent that lets other things correctly set the first mobstate stuff. I needed it for Alive actions.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Escargot and snails! Hopefully you don't encounter that one snail...

@github-actions github-actions bot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

RSI Diff Bot; head commit 3c0f69d merging into 0d51839
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Animals/snail.rsi

State Old New Status
dead Added
snail Added
snoth Added
snothdead Added
spacedead Added
spacesnail Added

Resources/Textures/Objects/Consumable/Food/bowl.rsi

State Old New Status
escargot Added

Resources/Textures/Objects/Consumable/Food/meat.rsi

State Old New Status
snail-cooked Added
snail Added

Edit: diff updated after 3c0f69d

@Plykiya
Copy link
Contributor

Plykiya commented Aug 8, 2024 •
edited
Loading

I will code the proper midround antag snail if this gets merged

@IProduceWidgets
Copy link
Contributor Author

Test fail is real, it doesn't like the jetpack effect being spawned. It doesn't hurt anything, but its late and the resolution for it isn't jumping out at me immediately, so its a tomorrow problem.

@IProduceWidgets
Copy link
Contributor Author

It should pass tests now for review, I'm going to ponder what the right way to do the visual effect I want is.

@ps3moira
Copy link
Contributor

ps3moira commented Aug 8, 2024

once hallucinations are a thing and seeing the death snail...the horrors. awesome

@TeenSarlacc
Copy link
Contributor

immortal snail midround antag that can only kill one specific person?

lzk228
lzk228 suggested changes Aug 8, 2024
View reviewed changes
@Everturning
Copy link

Midroun antag that makes the person immortal/damage resistant until the snail touches them? Sounds fun

@Cadunkus
Copy link

Cadunkus commented Aug 9, 2024

Do snails take damage from salt? I'm not seeing anything with ctrl+F other than the snail meat is better with salt.

@IProduceWidgets
Copy link
Contributor Author

Do snails take damage from salt? I'm not seeing anything with ctrl+F other than the snail meat is better with salt.

Does now!

@Emisse
Copy link
Contributor

Emisse commented Aug 19, 2024

everything looks fine but mobstate change scares me

@deathride58 deathride58 added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 19, 2024
@slarticodefast slarticodefast added the S: Awaiting Changes Status: Changes are required before another review can happen label Aug 21, 2024
@slarticodefast slarticodefast merged commit c8e59eb into space-wizards:master Sep 3, 2024
13 checks passed
@slarticodefast slarticodefast mentioned this pull request Sep 3, 2024
Merged
2 tasks
@UbaserB UbaserB removed the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Sep 3, 2024
Erisfiregamer1 pushed a commit to The-Arcadis-Team/arc-station-14 that referenced this pull request Jan 9, 2025
@IProduceWidgets @sleepyyapril
Add Snails (space-wizards#30765)
48255db 
* add snails

* scuffix

* migrate

* mo-grate

* oopsied the ftls

* Revert "oopsied the ftls"

This reverts commit 0d3c6c1.

* the curse of staging the wrong file, resolved.

* Snoth

* fix my dumbs

* reviews 1

* anti space technology

* salt hurty

* spelling

* Its a slotherhouse out here

* sequencing

* cooked snail

* volfix

* speed reversal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth metalgearsloth left review comments

@slarticodefast slarticodefast slarticodefast left review comments

@lzk228 lzk228 lzk228 requested changes

@Emisse Emisse Emisse approved these changes

Assignees
No one assigned
Labels
Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Awaiting Changes Status: Changes are required before another review can happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.