Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo Mail System #35429

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

Cargo Mail System #35429

wants to merge 25 commits into from

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Feb 23, 2025 •
edited
Loading

About the PR

Added a cargo mail delivery system. TODO

Why / Balance

It cool. TODO

Technical details

C# code. TODO

Media

2025-02-23.19-34-12.mp4

Requirements

Breaking changes

TODO

  • Code cleanup
  • Docs
  • Sprites
  • Mail spawn amount based on amount of players
  • Loot tables for letters
  • Loot tables for packages
  • PriorityDelivery probably, for a funny modifier, most likely not though
  • Faking fingerprints with forensic papers (probably)

Changelog

🆑

  • add: Cargo now can deliver mail across the station!

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Feb 23, 2025
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Feb 23, 2025

This is like the first working draft, don't even bother reading the code. No cleanup or anything has been even done. GG

@YoungThugSS14
Copy link
Contributor

This is like the first working draft, don't even bother reading the code. No cleanup or anything has been even done. GG

We ball

@github-actions github-actions bot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

RSI Diff Bot; head commit cc41c67 merging into e540f9c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Cargo/mail.rsi

State Old New Status
broken Added
fragile Added
icon Added
locked Added
postmark Added
priority Added
priority_inactive Added
trash Added

Edit: diff updated after cc41c67

This was referenced Feb 24, 2025
Merged
Merged
Merged
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 24, 2025
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Feb 24, 2025

Ah gotta love its all seperate commits

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Feb 24, 2025

This stays between us, public github commets

@ArtisticRoomba
Copy link
Contributor

I know what you did

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Feb 27, 2025

Well this has entered playtestable age.
All the basic stuff is in there and needs cleanup + sprites finished

@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Feb 28, 2025
@Everturning
Copy link

can you make it so forensic papers with a person's fingerprints on them can open the mail when pressed to the letter?

obstruction of correspondence gaming

@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Feb 28, 2025

can you make it so forensic papers with a person's fingerprints on them can open the mail when pressed to the letter?
obstruction of correspondence gaming

Unsure if I will but I like this idea, ill try

@BramvanZijp BramvanZijp added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. A: Cargo/Salvage Area: Cargo department or Salvage. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Mar 1, 2025
@ScarKy0 ScarKy0 mentioned this pull request Mar 1, 2025
Open
2 tasks
@ScarKy0 ScarKy0 added the S: Draft Status: This is a draft and might need to be retriaged upon opening. label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Cargo/Salvage Area: Cargo department or Salvage. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Draft Status: This is a draft and might need to be retriaged upon opening. size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ScarKy0 @YoungThugSS14 @ArtisticRoomba @Everturning @BramvanZijp @MilonPL