Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix being able to write on/stamp/fax paper scrap #35596

Merged
merged 4 commits into from
Mar 1, 2025
Merged

Fix being able to write on/stamp/fax paper scrap #35596

merged 4 commits into from
Mar 1, 2025
+37 −36

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Mar 1, 2025 •
edited
Loading

About the PR

Did you know you can write on paper scrap? And that it breaks the sprite quite a bit? Well now you do.
I made Paper inherit BasePaper and BaseWritablePaper, while paper scrap only inherits BasePaper

Why / Balance

It didn't look intentional

Technical details

Made BasePaper. Made Paper and PaperScrap parent accordingly.

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: You can no longer fax, stamp or write on paper scrap.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Mar 1, 2025
@ScarKy0 ScarKy0 requested a review from ArtisticRoomba March 1, 2025 10:20
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Mar 1, 2025
@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. labels Mar 1, 2025
@ScarKy0
Copy link
Contributor Author

ScarKy0 commented Mar 1, 2025

Half needed for #35429 as it makes paper scraps way more common

@ScarKy0 ScarKy0 requested a review from slarticodefast March 1, 2025 13:03
@ScarKy0 ScarKy0 changed the title Seperate Paper into BasePaper and BaseWritablePaper Fix being able to write on/stamp/fax paper scrap Mar 1, 2025
@slarticodefast slarticodefast merged commit 5169ad4 into space-wizards:master Mar 1, 2025
12 checks passed
@ScarKy0 ScarKy0 deleted the paper-proto-cleanup branch March 1, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

@ArtisticRoomba ArtisticRoomba Awaiting requested review from ArtisticRoomba

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScarKy0 @slarticodefast