Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove confusing clock warning #5163

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Remove confusing clock warning #5163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11905c5
Remove confusing clock warning
lrettig Oct 16, 2023
1365b04
Review feedback
lrettig Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion timesync/clock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@
)
d := t.lastTicked.Difference(layer)
tickDistance.Observe(float64(-d))
case layer.Difference(t.lastTicked) > 1:
// don't warn right after fresh startup
case layer.Difference(t.lastTicked) > 1 && t.lastTicked > 0:

Check warning on line 140 in timesync/clock.go

View check run for this annotation

Codecov / codecov/patch

timesync/clock.go#L140 

Added line #L140 was not covered by tests
t.log.With().Warning("clock skipped layers",
log.Stringer("layer", layer),
log.Stringer("last_ticked_layer", t.lastTicked),
Expand Down