Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove confusing clock warning #5163

Closed
wants to merge 2 commits into from

Conversation

lrettig
Copy link
Member

@lrettig lrettig commented Oct 16, 2023

Don't warn about skipping layers right after fresh start. This causes constant confusion among community members.

Don't warn about skipping layers right after fresh start
timesync/clock.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #5163 (1365b04) into develop (156d084) will increase coverage by 0.0%.
Report is 3 commits behind head on develop.
The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           develop   #5163    +/-   ##
========================================
  Coverage     77.6%   77.7%            
========================================
  Files          259     259            
  Lines        30457   30750   +293     
========================================
+ Hits         23644   23902   +258     
- Misses        5322    5357    +35     
  Partials      1491    1491            
Files Coverage Δ
timesync/clock.go 84.9% <0.0%> (-6.2%) ⬇️

... and 6 files with indirect coverage changes

@dshulyak dshulyak removed the area/log label Oct 16, 2023
Combine conditional, drop metrics as well right after startup
@lrettig lrettig added the log label Oct 16, 2023
@lrettig
Copy link
Member Author

lrettig commented Oct 16, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 16, 2023
Don't warn about skipping layers right after fresh start. This causes constant confusion among community members.
@bors
Copy link

bors bot commented Oct 16, 2023

Build failed:

@lrettig
Copy link
Member Author

lrettig commented Oct 16, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 16, 2023
Don't warn about skipping layers right after fresh start. This causes constant confusion among community members.
@bors
Copy link

bors bot commented Oct 16, 2023

Build failed:

@fasmat
Copy link
Member

fasmat commented Oct 17, 2023

The merge failed twice because of the node not being able to connect to 0.0.0.0 to submit a challenge to PoET in TestAdminEvents. #5165 should fix that issue.

@fasmat
Copy link
Member

fasmat commented Oct 17, 2023

bors merge

bors bot pushed a commit that referenced this pull request Oct 17, 2023
Don't warn about skipping layers right after fresh start. This causes constant confusion among community members.
@bors
Copy link

bors bot commented Oct 17, 2023

Build failed:

@fasmat
Copy link
Member

fasmat commented Oct 17, 2023

flaky test: #4668

bors merge

bors bot pushed a commit that referenced this pull request Oct 17, 2023
Don't warn about skipping layers right after fresh start. This causes constant confusion among community members.
@bors
Copy link

bors bot commented Oct 17, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Remove confusing clock warning [Merged by Bors] - Remove confusing clock warning Oct 17, 2023
@bors bors bot closed this Oct 17, 2023
@bors bors bot deleted the clock-skipped-log-fix branch October 17, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants