[Merged by Bors] - Try possible fix for flaky TestAdminEvents on Windows #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5165 +/- ##
=========================================
+ Coverage 77.6% 77.7% +0.1%
=========================================
Files 259 259
Lines 30457 30750 +293
=========================================
+ Hits 23644 23909 +265
- Misses 5322 5350 +28
Partials 1491 1491
|
dshulyak
approved these changes
Oct 17, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
## Motivation Instead of trying to access the local PoET via `0.0.0.0:10010` access it via `127.0.0.1:10010`. The first address seems to cause problems on some Windows systems ## Changes Updated standalone config to use 127.0.0.1 for local addresses instead of 0.0.0.0 ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
poszu
pushed a commit
that referenced
this pull request
Oct 17, 2023
## Motivation Instead of trying to access the local PoET via `0.0.0.0:10010` access it via `127.0.0.1:10010`. The first address seems to cause problems on some Windows systems ## Changes Updated standalone config to use 127.0.0.1 for local addresses instead of 0.0.0.0 ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Closed
4 tasks
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…5172) ## Motivation Follow up to #5165 Additionally to Windows not liking `0.0.0.0` as connection address, the Windows GH runners sometimes disallow to listen on port 50002 (default for PoET gRPC). It seems to be an issue with some of the windows runners, since no other test uses a standalone PoET (so nothing should be listening there already) and it only appears to happen on Windows. Assigning a random (free) port as listen address seems generally a good idea (for parallelisation, less likely to fail, etc.) ## Changes - changed `RawRPCListener` to use a random port instead of the default one if node is launched in standalone mode ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…5172) ## Motivation Follow up to #5165 Additionally to Windows not liking `0.0.0.0` as connection address, the Windows GH runners sometimes disallow to listen on port 50002 (default for PoET gRPC). It seems to be an issue with some of the windows runners, since no other test uses a standalone PoET (so nothing should be listening there already) and it only appears to happen on Windows. Assigning a random (free) port as listen address seems generally a good idea (for parallelisation, less likely to fail, etc.) ## Changes - changed `RawRPCListener` to use a random port instead of the default one if node is launched in standalone mode ## Test Plan n/a ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of trying to access the local PoET via
0.0.0.0:10010access it via127.0.0.1:10010. The first address seems to cause problems on some Windows systemsChanges
Updated standalone config to use 127.0.0.1 for local addresses instead of 0.0.0.0
Test Plan
n/a
TODO