Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Simplify code in fetch and syncer pkgs #5453

Closed
wants to merge 12 commits into from

Remove callbacks from fetch::poll

6ab4d1a
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - Simplify code in fetch and syncer pkgs #5453

Remove callbacks from fetch::poll
6ab4d1a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 17, 2024 in 1s

69.6% of diff hit (target 77.6%)

View this Pull Request on Codecov

69.6% of diff hit (target 77.6%)

Annotations

Check warning on line 420 in fetch/fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/fetch.go#L416-L420 

Added lines #L416 - L420 were not covered by tests

Check warning on line 191 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L191 

Added line #L191 was not covered by tests

Check warning on line 216 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L216 

Added line #L216 was not covered by tests

Check warning on line 225 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L225 

Added line #L225 was not covered by tests

Check warning on line 231 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L231 

Added line #L231 was not covered by tests

Check warning on line 233 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L233 

Added line #L233 was not covered by tests

Check warning on line 280 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L280 

Added line #L280 was not covered by tests

Check warning on line 303 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L303 

Added line #L303 was not covered by tests

Check warning on line 333 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L332-L333 

Added lines #L332 - L333 were not covered by tests

Check warning on line 344 in fetch/mesh_data.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

fetch/mesh_data.go#L341-L344 

Added lines #L341 - L344 were not covered by tests

Check warning on line 241 in p2p/server/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

p2p/server/server.go#L241 

Added line #L241 was not covered by tests

Check warning on line 262 in p2p/server/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

p2p/server/server.go#L259-L262 

Added lines #L259 - L262 were not covered by tests

Check warning on line 61 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L60-L61 

Added lines #L60 - L61 were not covered by tests

Check warning on line 71 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L66-L71 

Added lines #L66 - L71 were not covered by tests

Check warning on line 80 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L76-L80 

Added lines #L76 - L80 were not covered by tests

Check warning on line 96 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L95-L96 

Added lines #L95 - L96 were not covered by tests

Check warning on line 111 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L110-L111 

Added lines #L110 - L111 were not covered by tests

Check warning on line 120 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L119-L120 

Added lines #L119 - L120 were not covered by tests

Check warning on line 129 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L125-L129 

Added lines #L125 - L129 were not covered by tests

Check warning on line 232 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L232 

Added line #L232 was not covered by tests

Check warning on line 242 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L241-L242 

Added lines #L241 - L242 were not covered by tests

Check warning on line 257 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L255-L257 

Added lines #L255 - L257 were not covered by tests

Check warning on line 259 in syncer/data_fetch.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

syncer/data_fetch.go#L259 

Added line #L259 was not covered by tests
View more details on Codecov