Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Simplify code in fetch and syncer pkgs #5453

Closed
wants to merge 12 commits into from

Remove callbacks from fetch::poll

6ab4d1a
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - Simplify code in fetch and syncer pkgs #5453

Remove callbacks from fetch::poll
6ab4d1a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2024 in 0s

77.6% (-0.1%) compared to 6fb4cb4

View this Pull Request on Codecov

77.6% (-0.1%) compared to 6fb4cb4

Details

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (6fb4cb4) 77.6% compared to head (6ab4d1a) 77.6%.
Report is 1 commits behind head on develop.

❗ Current head 6ab4d1a differs from pull request most recent head 09d597e. Consider uploading reports for the commit 09d597e to get more accurate results

Files Patch % Lines
syncer/data_fetch.go 67.7% 31 Missing and 8 partials ⚠️
fetch/mesh_data.go 66.6% 13 Missing and 4 partials ⚠️
fetch/fetch.go 78.5% 5 Missing and 1 partial ⚠️
p2p/server/server.go 76.1% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5453     +/-   ##
=========================================
- Coverage     77.6%   77.6%   -0.1%     
=========================================
  Files          266     266             
  Lines        30889   30740    -149     
=========================================
- Hits         23999   23866    -133     
+ Misses        5375    5369      -6     
+ Partials      1515    1505     -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.