[Merged by Bors] - Don't allow post service connection if no coinbase is set #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan4th
reviewed
Apr 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5819 +/- ##
=======================================
Coverage 80.2% 80.3%
=======================================
Files 286 286
Lines 29798 29764 -34
=======================================
- Hits 23924 23917 -7
+ Misses 4224 4195 -29
- Partials 1650 1652 +2 ☔ View full report in Codecov by Sentry. |
poszu
reviewed
Apr 9, 2024
poszu
approved these changes
Apr 9, 2024
fasmat
force-pushed
the
refuse-post-service-connections-no-coinbase
branch
from
e27387e to
fcda067
Compare
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
## Motivation The node should refuse connections from Post services when no coinbase for smeshing is set, because the ATX Builder won't be able to build ATXs then.
|
This PR was included in a batch that was canceled, it will be automatically retried |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
## Motivation The node should refuse connections from Post services when no coinbase for smeshing is set, because the ATX Builder won't be able to build ATXs then.
|
Build failed (retrying...): |
|
Canceled. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
## Motivation The node should refuse connections from Post services when no coinbase for smeshing is set, because the ATX Builder won't be able to build ATXs then.
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
## Motivation The node should refuse connections from Post services when no coinbase for smeshing is set, because the ATX Builder won't be able to build ATXs then.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
spacemesh-bors
bot
deleted the
refuse-post-service-connections-no-coinbase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The node should refuse connections from Post services when no coinbase for smeshing is set, because the ATX Builder won't be able to build ATXs then.
Description
Registercalls by clients are allowed or notfalseif no coinbase is set in the nodes config andtrueif there is a coinbase setStartSmeshingcall, because it sets a coinbase address with the requestTest Plan
TODO