Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Improve performance of proposal builder by not DB inserting active set if not necessary #6422

Closed
wants to merge 7 commits into from

Fix typo

2f8aa8e
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - Improve performance of proposal builder by not DB inserting active set if not necessary #6422

Fix typo
2f8aa8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 29, 2024 in 0s

79.7% (+0.0%) compared to d32ffaa

View this Pull Request on Codecov

79.7% (+0.0%) compared to d32ffaa

Details

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.7%. Comparing base (d32ffaa) to head (2f8aa8e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
miner/proposal_builder.go 85.7% 2 Missing and 1 partial ⚠️
sql/database.go 50.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #6422   +/-   ##
=======================================
  Coverage     79.7%   79.7%           
=======================================
  Files          328     328           
  Lines        42977   42984    +7     
=======================================
+ Hits         34256   34292   +36     
+ Misses        6782    6753   -29     
  Partials      1939    1939           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.