Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert astropy prerelease wheel spec and use nightly Scipy wheel index #101

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

zacharyburnett
Copy link
Collaborator

This PR addresses @WilliamJamieson's comments in spacetelescope/romancal#695 (comment); the change to the Astropy dev spec in #100 didn't actually accomplish anything, and numpy wheels are hosted at a different index URL

@zacharyburnett zacharyburnett self-assigned this May 10, 2023
@zacharyburnett
Copy link
Collaborator Author

GitHub Actions are currently degraded; running tox -e test-devdeps-xdist locally results in the following pip freeze:

asdf==2.15.0
asdf-standard==1.0.3
asdf-transform-schemas==0.3.0
asdf-unit-schemas==0.1.0
astropy @ git+https://github.com/astropy/astropy.git@f2fbb112983e953fb772c5ac81ec50dfa34bcc19
attrs==23.1.0
certifi==2023.5.7
charset-normalizer==3.1.0
ci-watson==0.6.1
crds==11.17.0
drizzle @ file:///Users/zburnett/projects/drizzle/.tox/.tmp/package/3/drizzle-1.13.8.dev21%2Bg99bdbf5-0.editable-cp311-cp311-macosx_12_0_x86_64.whl#sha256=5dc000760288780c58186bf51674b77b53f89e16b3606141e55b2457ae7e8abe
filelock==3.12.0
idna==3.4
importlib-metadata==6.6.0
iniconfig==2.0.0
jmespath==1.0.1
jsonschema==4.17.3
numpy==1.24.3
packaging==23.1
Parsley==1.3
pluggy==1.0.0
pyerfa==2.0.0.3
pyrsistent==0.19.3
pytest==7.3.1
PyYAML==6.0
requests==2.30.0
semantic-version==2.10.0
urllib3==2.0.2
zipp==3.15.0

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented May 10, 2023

removing the accidental comment from the parameter (#egg=astropy) uncommented the -U --upgrade-strategy eager and allowed numpy to be upgraded to the nightly wheel

asdf==2.15.0
asdf-standard==1.0.3
asdf-transform-schemas==0.3.0
asdf-unit-schemas==0.1.0
astropy @ git+https://github.com/astropy/astropy@f2fbb112983e953fb772c5ac81ec50dfa34bcc19
attrs==23.1.0
certifi==2023.5.7
charset-normalizer==3.1.0
ci-watson==0.6.1
crds==11.17.0
drizzle @ file:///Users/zburnett/projects/drizzle/.tox/.tmp/package/4/drizzle-1.13.8.dev21%2Bg99bdbf5.d20230510-0.editable-cp311-cp311-macosx_12_0_x86_64.whl#sha256=e47b967c52a43343084d02a477cfd7e0152a4ee6a46d30adba4348cf552253a8
execnet==1.9.0
filelock==3.12.0
idna==3.4
importlib-metadata==6.6.0
iniconfig==2.0.0
jmespath==1.0.1
jsonschema==4.17.3
numpy==1.25.0.dev0+1357.ga2d21d8ac
packaging==23.1
Parsley==1.3
pluggy==1.0.0
pyerfa==2.0.0.3
pyrsistent==0.19.3
pytest==7.3.1
pytest-xdist==3.2.1
PyYAML==6.0
requests==2.30.0
semantic-version==2.10.0
urllib3==2.0.2
zipp==3.15.0

@zacharyburnett zacharyburnett marked this pull request as ready for review May 10, 2023 14:30
@zacharyburnett zacharyburnett requested a review from a team as a code owner May 10, 2023 14:30
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (71f7d74) 75.29% compared to head (b658529) 75.29%.

❗ Current head b658529 differs from pull request most recent head 1a236d5. Consider uploading reports for the commit 1a236d5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files           7        7           
  Lines         344      344           
=======================================
  Hits          259      259           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcara
Copy link
Member

mcara commented May 18, 2023

I think #98 must be done first and this PR rebased after #98 is merged.

tox.ini Outdated Show resolved Hide resolved
@nden
Copy link
Contributor

nden commented Jun 8, 2023

The failure is unrelated

@nden nden merged commit 8c7452d into spacetelescope:master Jun 8, 2023
@zacharyburnett zacharyburnett deleted the devdeps_fix branch June 8, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants