test against nightly builds of astropy, scipy, and numpy
#695
Conversation
github-actions
bot
added
the
dependencies
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 77.70% 77.70%
=======================================
Files 80 80
Lines 4284 4284
=======================================
Hits 3329 3329
Misses 955 955
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
for some reason, the installed version of I'll investigate 🔍 |
| @@ -1,11 +1,13 @@ | |||
| git+https://github.com/asdf-format/asdf | |||
| git+https://github.com/asdf-format/asdf-transform-schemas | |||
| git+https://github.com/asdf-format/asdf-wcs-schemas | |||
| git+https://github.com/astropy/astropy | |||
| astropy>=0.0.dev0 | |||
There was a problem hiding this comment.
This change is actually exactly counter to the purpose of testing against a "nightly build" for astropy. Note that as far as I am aware, there are no "nightly builds" for astropy.
The previous configuration will use the latest dev version (literally the head of astropy's main branch). This by definition will cover all changes included in any astropy release candidate.
| git+https://github.com/astropy/asdf-astropy | ||
| git+https://github.com/spacetelescope/crds | ||
| git+https://github.com/spacetelescope/gwcs | ||
| numpy>=0.0.dev0 |
There was a problem hiding this comment.
This change does absolutely nothing in the context of the rest of the changes here. In fact, one can see in the CI: https://github.com/spacetelescope/romancal/actions/runs/4926111203/jobs/8801225303#step:10:265 that it is using numpy 1.24.3 which is the latest release version of numpy NOT some "nightly-build".
If you want to use this to actually access the nightly builds (which in reality are more like weekly builds), you need to specify an alternate index for pip to search.
For example https://github.com/astropy/astropy/blob/337798f36c9aa2ae98190c5819bde758d3aa5a40/tox.ini#L27 specifies the "nightly-build" provided by anaconda.
| git+https://github.com/spacetelescope/roman_datamodels | ||
| scipy>=0.0.dev0 |
There was a problem hiding this comment.
Same as numpy comment.
Related to SCSB-69
This PR ensures that
astropy,scipy, andnumpyare all built with nightly wheels againstmainChecklist
added entry inCHANGES.rstunder the corresponding subsectionupdated relevant documentationupdated relevant milestone(s)