Fix units issue with parameterless transform models #562
+127
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 85.96% 86.03% +0.06%
==========================================
Files 27 27
Lines 4025 4052 +27
==========================================
+ Hits 3460 3486 +26
- Misses 565 566 +1 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
bugfix/parameterless_units
branch
from
7aae725 to
e67f6cd
Compare
This fixes the bug so that gwcs works as it currently states. Its also not perfect as the issue lies up in astropy.modeling not gwcs itself.
WilliamJamieson
force-pushed
the
bugfix/parameterless_units
branch
from
085eece to
602c16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #558.
This fix is a bandaid fix until a fix upstream in
astropy.modelingcan be worked out. Note that this does not address the API issues expressed in #558, those are now being tracked by #561.