Refactor Coordinate Frames #567
Draft
+1,774
−1,201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 85.96% 86.50% +0.54%
==========================================
Files 27 40 +13
Lines 4025 4165 +140
==========================================
+ Hits 3460 3603 +143
+ Misses 565 562 -3 ☔ View full report in Codecov by Sentry. |
This was largely an issue of the zip(strict=False) causing missed entries. I made this strict=True
…trip to directly on the bounding box
This fixes the bug so that gwcs works as it currently states. Its also not perfect as the issue lies up in astropy.modeling not gwcs itself.
This also adds mypy checking in a way to support gradual adoption of type hints.
WilliamJamieson
force-pushed
the
refactor/coordinates
branch
from
0d0879d to
be55069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
coordinate_framesmodule, splitting it into submodules and fully implementing type hints to describe its API.Note that this PR is built on #562 and #563 so those PRs should be merged first.