JP-3705: Remove deprecated nlow and nhigh parameters from outlier det…

…ection step (#8870)

Co-authored-by: Melanie Clarke <[email protected]>

changes/8870.outlier_detection.rst

@@ -0,0 +1 @@
+Remove deprecated nlow and nhigh parameters from outlier detection step.

docs/jwst/outlier_detection/arguments.rst

@@ -25,14 +25,6 @@ that control the behavior of the processing:
   Any floating-point value, given as a string, is valid.
   A value of 'INDEF' will use the last zero weight flux.
 
-``--nlow``
-  Deprecated and has no effect. This parameter will be removed
-  in a future version.
-
-``--nhigh``
-  Deprecated and has no effect. This parameter will be removed
-  in a future version.
-
 ``--maskpt``
   The percent of maximum weight to use as lower-limit for valid data;
   valid values go from 0.0 to 1.0.

jwst/outlier_detection/outlier_detection_step.py

@@ -20,14 +20,6 @@
 TSO_IMAGE_MODES = ['NRC_TSIMAGE']  # missing MIR_IMAGE with TSOVIST=True, not really addable
 CORON_IMAGE_MODES = ['NRC_CORON', 'MIR_LYOT', 'MIR_4QPM']
 
-_STEP_MODES = {
-    'coron': coron,
-    'ifu': ifu,
-    'imaging': imaging,
-    'tso': tso,
-    'spec': spec,
-}
-
 __all__ = ["OutlierDetectionStep"]
 
 
@@ -52,8 +44,6 @@ class OutlierDetectionStep(Step):
         pixfrac = float(default=1.0)
         kernel = string(default='square') # drizzle kernel
         fillval = string(default='INDEF')
-        nlow = integer(default=0)  # DEPRECATED this setting has no effect and will be removed
-        nhigh = integer(default=0)  # DEPRECATED this setting has no effect and will be removed
         maskpt = float(default=0.7)
         snr = string(default='5.0 4.0')
         scale = string(default='1.2 0.7')