Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jump detection tests #6310

Merged

Conversation

cshanahan1
Copy link
Collaborator

Small change in tests for jump detection. This along with spacetelescope/stcal#44 can close #6234

@cshanahan1 cshanahan1 requested review from jdavies-st and nden and removed request for jdavies-st August 27, 2021 13:58
@cshanahan1 cshanahan1 force-pushed the jump_flag_all_pixels_MIRI_3_group_ints branch from a36a2d3 to c3e96fc Compare October 8, 2021 19:36
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #6310 (9e56afa) into master (602b6c9) will decrease coverage by 0.40%.
The diff coverage is n/a.

❗ Current head 9e56afa differs from pull request most recent head 6d5da56. Consider uploading reports for the commit 6d5da56 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6310      +/-   ##
==========================================
- Coverage   77.70%   77.30%   -0.41%     
==========================================
  Files         408      408              
  Lines       34903    35040     +137     
==========================================
- Hits        27120    27086      -34     
- Misses       7783     7954     +171     
Flag Coverage Δ *Carryforward flag
nightly 77.59% <ø> (-0.12%) ⬇️ Carriedforward from 066f696
unit 56.39% <ø> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/regtest/conftest.py 64.67% <0.00%> (-23.37%) ⬇️
jwst/extract_1d/extract.py 70.96% <0.00%> (-6.56%) ⬇️
jwst/rscd/rscd_step.py 72.41% <0.00%> (-3.45%) ⬇️
jwst/regtest/regtestdata.py 85.32% <0.00%> (-1.84%) ⬇️
jwst/datamodels/wcs_ref_models.py 76.86% <0.00%> (-0.05%) ⬇️
jwst/wfs_combine/wfs_combine_step.py 100.00% <0.00%> (ø)
jwst/associations/lib/rules_level2b.py 96.70% <0.00%> (ø)
jwst/datamodels/fringefreq.py
jwst/datamodels/residualfringe.py 100.00% <0.00%> (ø)
jwst/residual_fringe/residual_fringe_step.py 13.84% <0.00%> (+0.20%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929fb36...6d5da56. Read the comment docs.

@cshanahan1 cshanahan1 force-pushed the jump_flag_all_pixels_MIRI_3_group_ints branch from bce4660 to 6d5da56 Compare October 13, 2021 20:55
@nden
Copy link
Collaborator

nden commented Oct 13, 2021

The installed package test is running for 2 hours now. Seems to be stuck.

@nden nden merged commit b6155a6 into spacetelescope:master Oct 13, 2021
cshanahan1 added a commit to cshanahan1/jwst that referenced this pull request Oct 14, 2021
jdavies-st pushed a commit that referenced this pull request Oct 14, 2021
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
loicalbert pushed a commit to talensgj/jwst that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants