JP-2206: fix jump for miri 3 and 4 group ints #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 21.99% 21.72% -0.27%
==========================================
Files 14 14
Lines 1614 1611 -3
==========================================
- Hits 355 350 -5
- Misses 1259 1261 +2
Continue to review full report at Codecov.
|
cshanahan1
force-pushed
the
jump_flag_all_pixels_MIRI_3_group_ints
branch
from
c933dff to
f06613f
Compare
cshanahan1
force-pushed
the
jump_flag_all_pixels_MIRI_3_group_ints
branch
from
f06613f to
41e1fa9
Compare
|
@cshanahan1 This may need a rebase because of a fix for jwst in #49 |
jdavies-st
reviewed
Aug 27, 2021
CHANGES.rst
Outdated
Comment on lines
6
to
11
| jump_detection | ||
| -------------- | ||
| - Fix issue with flagging for MIRI three and four group integrations. (#44) | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This needs to go in a 0.2.5 (unreleased) section, as 0.2.4 is already released.
jdavies-st
changed the title
cshanahan1
force-pushed
the
jump_flag_all_pixels_MIRI_3_group_ints
branch
from
41e1fa9 to
b235456
Compare
nden
requested changes
Oct 8, 2021
| @@ -21,6 +21,11 @@ ramp_fitting | |||
| Workaround for setuptools_scm issues with recent versions of pip. [#45] | |||
|
|
|||
|
|
|||
| jump_detection | |||
| -------------- | |||
| - Fix issue with flagging for MIRI three and four group integrations. (#44) | |||
There was a problem hiding this comment.
Sorry, this needs to be moved again - to the 0.4. section
cshanahan1
force-pushed
the
jump_flag_all_pixels_MIRI_3_group_ints
branch
from
b235456 to
b335493
Compare
nden
approved these changes
Oct 13, 2021
|
Merging, so we can release and update jwst. |
jdavies-st
added a commit
to jdavies-st/stcal
that referenced
this pull request
Oct 14, 2021
This reverts commit cabd41e.
jdavies-st
added a commit
that referenced
this pull request
Oct 14, 2021
This reverts commit cabd41e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves spacetelescope/jwst#6223 / JP-2206
Closes spacetelescope/jwst#6234
Code derived from @mwregan2 's PR above.
This has a corresponding PR in jwst to fix some tests that also needs to be merged: spacetelescope/jwst#6310. This PR should be merged and stcal should be released before that one is merged.