override package dependencies with requirements file when requested #7557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7557 +/- ##
==========================================
+ Coverage 77.57% 77.58% +0.01%
==========================================
Files 455 455
Lines 36348 36367 +19
==========================================
+ Hits 28197 28216 +19
Misses 8151 8151
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
2 tasks
zacharyburnett
force-pushed
the
reorder_deps_install
branch
from
b278c71 to
f877055
Compare
zacharyburnett
force-pushed
the
reorder_deps_install
branch
from
f877055 to
e5936c7
Compare
hbushouse
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SCSB-66
Currently,
toxinstalls therequirements-sdp.txtorrequirements-dev.txtbefore installing the package withpip install .; this could result in the possible edge case where package dependencies override the requirements file, where the opposite should be the case:https://github.com/spacetelescope/jwst/actions/runs/4743917678/jobs/8424099673#step:10:14
In fact, this edge case triggers right now in the
test-devdeps-xdistCI job, becausestdatamodelsis pinned below1.4.0and the latest commit is past1.4.0:https://github.com/spacetelescope/jwst/actions/runs/4743917678/jobs/8424100250#step:10:16
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionupdated relevant documentationadded relevant milestoneran regression tests, post a link to the Jenkins job below.How to run regression tests on a PR