Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override package dependencies with requirements file when requested #685

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 20, 2023

Resolves SCSB-66

Currently, tox installs the requirements-dev.txt before installing the package with pip install .; this could result in the possible edge case where package dependencies override the requirements file, where the opposite should be the case, as seen in spacetelescope/jwst#7557

Checklist

  • [N/A] added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • [N/A] updated relevant documentation
  • [N/A] updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (21c1358) 64.51% compared to head (6b235e3) 64.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   64.51%   64.51%           
=======================================
  Files          78       78           
  Lines        4106     4106           
=======================================
  Hits         2649     2649           
  Misses       1457     1457           
Flag Coverage Δ *Carryforward flag
nightly 63.59% <ø> (ø) Carriedforward from 21c1358

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review April 21, 2023 12:04
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 21, 2023 12:04
@zacharyburnett
Copy link
Collaborator Author

docs have the deprecation warning from asdf-format/sphinx-asdf#58

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit f11fece into spacetelescope:main Apr 21, 2023
@zacharyburnett zacharyburnett deleted the reorder_deps_install branch April 21, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants