Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] run pip list after installing override requirements in Jenkins #7596

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jun 5, 2023

analogous to spacetelescope/romancal#711 (review)

Currently the pip freeze happens after the initial dependency install, but before the OVERRIDE_REQUIREMENTS option is handled by Jenkins. This makes it difficult to see if Jenkins has successfully installed an overriden requirement for the test run. This PR adds an additional pip list (same as pip freeze just more nicely formatted as a table) after the OVERRIDE_REQUIREMENTS are applied so that one can check in the Jenkins job log to make sure overriden requirements have successfully installed.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Jun 5, 2023
@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools regression_testing labels Jun 5, 2023
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Jun 5, 2023

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c20b833) 77.48% compared to head (da3288a) 77.48%.

❗ Current head da3288a differs from pull request most recent head baad926. Consider uploading reports for the commit baad926 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7596      +/-   ##
==========================================
- Coverage   77.48%   77.48%   -0.01%     
==========================================
  Files         456      456              
  Lines       36592    36591       -1     
==========================================
- Hits        28355    28354       -1     
  Misses       8237     8237              
Flag Coverage Δ *Carryforward flag
nightly 77.54% <ø> (ø) Carriedforward from 21c7b51

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett changed the title [CI] run pip list after installing override requirements in Jenkins [CI] run pip list after installing override requirements in Jenkins Jun 5, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review June 5, 2023 17:41
@zacharyburnett zacharyburnett requested a review from a team as a code owner June 5, 2023 17:41
@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Jun 5, 2023

@hbushouse hbushouse added this to the Build 9.3 milestone Jun 13, 2023
@zacharyburnett zacharyburnett enabled auto-merge June 13, 2023 13:29
@zacharyburnett zacharyburnett merged commit ac1a587 into spacetelescope:master Jun 13, 2023
@zacharyburnett zacharyburnett deleted the pip_list_after_override branch September 23, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed regression_testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants