Add a pip list step after the overrides are injected
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 75.51% 75.51%
=======================================
Files 90 90
Lines 5452 5452
=======================================
Hits 4117 4117
Misses 1335 1335
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
regression/add_list
branch
from
aef5011 to
300f0d2
Compare
zacharyburnett
requested changes
Jun 5, 2023
WilliamJamieson
force-pushed
the
regression/add_list
branch
from
300f0d2 to
fa7d811
Compare
WilliamJamieson
force-pushed
the
regression/add_list
branch
from
fa7d811 to
734c336
Compare
zacharyburnett
approved these changes
Jun 5, 2023
7 tasks
WilliamJamieson
force-pushed
the
regression/add_list
branch
3 times, most recently
from
de53cfb to
3a9f8f5
Compare
Currently the pip freeze happens after the initial dependency install, but before the OVERRIDE_REQUIREMENTS option is handled by Jenkins. This makes it difficult to see if Jenkins has successfully installed an overriden requirement for the test run.
WilliamJamieson
force-pushed
the
regression/add_list
branch
from
3a9f8f5 to
753d4d6
Compare
|
It works just fine, see the list here: |
|
The regession tests did pass: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/233/ |
mairanteodoro
pushed a commit
to mairanteodoro/romancal
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the pip freeze happens after the initial dependency install, but before the OVERRIDE_REQUIREMENTS option is handled by Jenkins. This makes it difficult to see if Jenkins has successfully installed an overriden requirement for the test run. This PR adds an additional
pip list(same aspip freezejust more nicely formatted as a table) after the OVERRIDE_REQUIREMENTS are applied so that one can check in the Jenkins job log to make sure overriden requirements have successfully installed.Checklist
CHANGES.rstunder the corresponding subsection