Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stdatamodels datamodels link in documentation #7657

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 28, 2023

Remove comment that made it's way into the data models docs and link to the now published stdatamodels docs.

Addresses comment: #7656 (comment)

Fixes: JP-3280

Link to updated datamodels docs built with this PR: https://jwst-pipeline--7657.org.readthedocs.build/en/7657/jwst/user_documentation/datamodels.html#jwst-datamodels

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram changed the title fix stdatamodels datamodels link fix stdatamodels datamodels link in documentation Jun 28, 2023
@braingram braingram marked this pull request as ready for review June 28, 2023 17:07
@braingram braingram requested a review from a team as a code owner June 28, 2023 17:07
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (403b9b3) 76.62% compared to head (515674b) 76.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7657   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files         456      456           
  Lines       36831    36831           
=======================================
  Hits        28221    28221           
  Misses       8610     8610           
Flag Coverage Δ *Carryforward flag
nightly 77.43% <ø> (ø) Carriedforward from 403b9b3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse added this to the Build 9.3 milestone Jun 29, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Docs built from this PR seem to have the correct link now.

@hbushouse hbushouse enabled auto-merge (squash) June 29, 2023 12:31
@hbushouse hbushouse disabled auto-merge June 29, 2023 12:31
@hbushouse hbushouse merged commit 359b9f5 into spacetelescope:master Jun 29, 2023
@braingram braingram deleted the docs/datamodels branch June 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants