Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more missing links to stdatamodels docs #7672

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 29, 2023

It appears #7657 was incomplete as while looking at other docs I found another broken link to and malformed comment about stdatamodels. I believe this PR should fix all the broken links and erroneous comments.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram braingram marked this pull request as ready for review June 29, 2023 19:42
@braingram braingram requested a review from a team as a code owner June 29, 2023 19:42
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1025a09) 76.62% compared to head (71a5306) 76.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7672   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files         456      456           
  Lines       36833    36833           
=======================================
  Hits        28223    28223           
  Misses       8610     8610           
Flag Coverage Δ *Carryforward flag
nightly 77.43% <ø> (ø) Carriedforward from 1025a09

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good. I would like to see a change log entry for this. List it under documentation.

@braingram
Copy link
Collaborator Author

Should I run regression tests on this PR or can those be skipped since it's only changing docs?

@hbushouse
Copy link
Collaborator

Should I run regression tests on this PR or can those be skipped since it's only changing docs?

regtests aren't necessary, for the reason you mention. Should check the docs build from the CI tests though, just to confirm that all the updated links are good now.

@braingram
Copy link
Collaborator Author

Should I run regression tests on this PR or can those be skipped since it's only changing docs?

regtests aren't necessary, for the reason you mention. Should check the docs build from the CI tests though, just to confirm that all the updated links are good now.

Thanks! The updated links all look good to me (links below are to pages which contain the updated links in the docs built with this PR):
https://jwst-pipeline--7672.org.readthedocs.build/en/7672/getting_started/quickstart.html#
https://jwst-pipeline--7672.org.readthedocs.build/en/7672/jwst/associations/overview.html#utilities
https://jwst-pipeline--7672.org.readthedocs.build/en/7672/jwst/model_blender/main.html#using-model-blender
https://jwst-pipeline--7672.org.readthedocs.build/en/7672/jwst/stpipe/user_step.html#configuring-a-step

@hbushouse hbushouse merged commit 8c40333 into spacetelescope:master Jun 30, 2023
@braingram braingram deleted the docs/datamodels2 branch June 30, 2023 20:15
@hbushouse hbushouse modified the milestones: Build 9.3, Build 10.0 Jul 3, 2023
@hbushouse hbushouse modified the milestones: Build 10.0, Build 9.3 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants