-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix more missing links to stdatamodels docs #7672
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7672 +/- ##
=======================================
Coverage 76.62% 76.62%
=======================================
Files 456 456
Lines 36833 36833
=======================================
Hits 28223 28223
Misses 8610 8610
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good. I would like to see a change log entry for this. List it under documentation
.
f7aef24
to
71a5306
Compare
Should I run regression tests on this PR or can those be skipped since it's only changing docs? |
regtests aren't necessary, for the reason you mention. Should check the docs build from the CI tests though, just to confirm that all the updated links are good now. |
Thanks! The updated links all look good to me (links below are to pages which contain the updated links in the docs built with this PR): |
It appears #7657 was incomplete as while looking at other docs I found another broken link to and malformed comment about stdatamodels. I believe this PR should fix all the broken links and erroneous comments.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR