remove requirements-max.txt

[braingram]

The requirements-max.txt file contains 2 upper pins:

jwst/requirements-max.txt

Lines 3 to 4 in 380dc5e

	stcal<1.6.0
	stdatamodels<1.10.0

and is used in the main (non-dev) jenkins file:

jwst/JenkinsfileRT

Line 77 in 380dc5e

bc0.pip_reqs_files = ['requirements-dev-st.txt', 'requirements-max.txt', 'requirements-sdp.txt']

This appears to be run after the pip list in the job which may mean that our regtests have been using a version of stcal that is lower than our minimum version listed in pyproject.toml:

jwst/pyproject.toml

Line 37 in 380dc5e

"stcal>=1.7.1,<1.8.0",

As requirements-max.txt is not used for the GA regression tests (and at the moment only show differences due to different machines) this PR removes the file (and the use in the jenkins regtests).

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• All comments are resolved
• Make sure the JIRA ticket is resolved properly

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.51%. Comparing base (dba65ae) to head (d668926).
Report is 384 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8574      +/-   ##
==========================================
+ Coverage   58.63%   59.51%   +0.88%     
==========================================
  Files         391      391              
  Lines       39081    39254     +173     
==========================================
+ Hits        22914    23362     +448     
+ Misses      16167    15892     -275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zacharyburnett]

good catch that it's installed after pip list! I remember we had to add requirements-max.txt for some reason, but I don't remember why exactly

[zacharyburnett]

looks like it was because of an issue with building a test environment, where we couldn't install user-requested dependencies on a Jenkins run if they were constrained by the upper pins in pyproject.toml: #7575

however, in the new GitHub Actions setup we install all "override" dependencies requested by the user as the last possible step, after the initial install, so this is no longer an issue

[braingram]

Regtests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1541/

[braingram]

I made a test branch that prints out the stcal and stdatamodels versions at the start of the pytest run:
master...braingram:jwst:test_max
and triggered a jenkins run (that ran only 1 test as only the header is useful for this test branch):
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1542/pipeline/194
The header included:

============================= test session starts ==============================
platform linux -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0
crds_context: jwst_1241.pmap
stcal: 1.7.3.dev6+g3fa4d42
stdatamodels: 1.10.1

Even though the requirements-max.txt file has stdatamodels<1.10.0. Looking at the console output for this run:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1542/consoleFull
I see the requirements-max.txt used (which installs an older version of stdatamodels) before pip install -e '.[test,sdp]' --no-cache-dir. (which uninstalls the older version and installs one above the pin in requirements-max.txt).

At this point I'm pretty confused about what conditions are required to have this requirements-max.txt have an effect (is it used for the non-PR job? is it used only for certain triggers of the job?).

[zacharyburnett]

At this point I'm pretty confused about what conditions are required to have this requirements-max.txt have an effect (is it used for the non-PR job? is it used only for certain triggers of the job?).

now I'm unsure if it ever worked at all, or was just a placebo PR... I don't see any reason to keep it