Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace upper pins on dependencies with requirements-max.txt #7575

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 28, 2023

Resolves SCSB-67

resolves spacetelescope/stdatamodels#157 (comment)

This PR removes upper pins on dependencies and adds requirements-max.txt to resolve issues not resolved by #7561

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5fdad6f) 77.56% compared to head (319d050) 77.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7575   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         455      455           
  Lines       36340    36340           
=======================================
  Hits        28188    28188           
  Misses       8152     8152           
Flag Coverage Δ *Carryforward flag
nightly 77.62% <ø> (ø) Carriedforward from 3b68693

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools regression_testing labels Apr 28, 2023
@zacharyburnett
Copy link
Collaborator Author

@zacharyburnett zacharyburnett changed the title remove upper pins on dependencies replace upper pins on dependencies with requirements-max.txt Apr 28, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review April 28, 2023 15:47
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 28, 2023 15:47
@zacharyburnett
Copy link
Collaborator Author

requirements-max.txt installs correctly: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/703/pipeline/123#step-189-log-26

Installing collected packages: stdatamodels
  Attempting uninstall: stdatamodels
    Found existing installation: stdatamodels 1.4.1.dev2+g21479e9
    Uninstalling stdatamodels-1.4.1.dev2+g21479e9:
      Successfully uninstalled stdatamodels-1.4.1.dev2+g21479e9
Successfully installed stdatamodels-1.4.0

@zacharyburnett
Copy link
Collaborator Author

aside from ephemeral socket errors, tests pass

@zacharyburnett zacharyburnett merged commit f856fba into spacetelescope:master Apr 28, 2023
@zacharyburnett zacharyburnett deleted the remove_upper_pins branch April 28, 2023 17:23
@zacharyburnett zacharyburnett mentioned this pull request Jun 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools installation no-changelog-entry-needed regression_testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants