Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3705: Remove deprecated nlow and nhigh parameters from outlier detection step #8870

Merged
merged 3 commits into from
Oct 10, 2024
Merged

JP-3705: Remove deprecated nlow and nhigh parameters from outlier detection step #8870

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dd2506
enforce deprecation of nlow and nhigh parameters to outlier detection
emolter Oct 10, 2024
a8c3355
added changelog entry
emolter Oct 10, 2024
77e0639
Update changes/8870.outlier_detection.rst
emolter Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/8870.outlier_detection.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
remove deprecated nlow and nhigh parameters from outlier detection step
emolter marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 0 additions & 8 deletions docs/jwst/outlier_detection/arguments.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ that control the behavior of the processing:
Any floating-point value, given as a string, is valid.
A value of 'INDEF' will use the last zero weight flux.

``--nlow``
Deprecated and has no effect. This parameter will be removed
in a future version.

``--nhigh``
Deprecated and has no effect. This parameter will be removed
in a future version.

``--maskpt``
The percent of maximum weight to use as lower-limit for valid data;
valid values go from 0.0 to 1.0.
Expand Down
10 changes: 0 additions & 10 deletions jwst/outlier_detection/outlier_detection_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@
TSO_IMAGE_MODES = ['NRC_TSIMAGE'] # missing MIR_IMAGE with TSOVIST=True, not really addable
CORON_IMAGE_MODES = ['NRC_CORON', 'MIR_LYOT', 'MIR_4QPM']

_STEP_MODES = {
'coron': coron,
'ifu': ifu,
'imaging': imaging,
'tso': tso,
'spec': spec,
}

__all__ = ["OutlierDetectionStep"]


Expand All @@ -52,8 +44,6 @@ class OutlierDetectionStep(Step):
pixfrac = float(default=1.0)
kernel = string(default='square') # drizzle kernel
fillval = string(default='INDEF')
nlow = integer(default=0) # DEPRECATED this setting has no effect and will be removed
nhigh = integer(default=0) # DEPRECATED this setting has no effect and will be removed
maskpt = float(default=0.7)
snr = string(default='5.0 4.0')
scale = string(default='1.2 0.7')
Expand Down
Loading