Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test against Astropy dev build and use nightly Scipy wheel index #252

Merged
merged 1 commit into from
May 11, 2023

Conversation

zacharyburnett
Copy link
Collaborator

Resolves SCSB-69

Partially reverts #249

This PR addresses @WilliamJamieson's comments in spacetelescope/romancal#695 (comment); numpy and scipy wheels are hosted at a different index URL. Additionally, adds Astropy's main branch to the dev dependencies, and installs them after the project

Checklist

@zacharyburnett zacharyburnett self-assigned this May 10, 2023
@zacharyburnett zacharyburnett changed the title use nightly Scipy wheel index test against Astropy dev build and use nightly Scipy wheel index May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (962893f) 93.54% compared to head (662a475) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           4        4           
  Lines         124      124           
=======================================
  Hits          116      116           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

GitHub Actions are currently degraded; running tox -e test-devdeps-xdist locally results in the following pip freeze:

asdf==2.15.0
asdf-astropy==0.4.0
asdf-coordinates-schemas==0.2.0
asdf-standard==1.0.3
asdf-transform-schemas==0.3.0
asdf-unit-schemas==0.1.0
astropy @ git+https://github.com/astropy/astropy.git@f2fbb112983e953fb772c5ac81ec50dfa34bcc19
attrs==23.1.0
execnet==1.9.0
importlib-metadata==6.6.0
iniconfig==2.0.0
jmespath==1.0.1
jsonschema==4.17.3
numpy==1.25.0.dev0+1357.ga2d21d8ac
packaging==23.1
pluggy==1.0.0
pyerfa==2.0.0.3
pyrsistent==0.19.3
pytest==7.3.1
pytest-doctestplus==0.12.1
pytest-xdist==3.2.1
PyYAML==6.0
rad @ file:///Users/zburnett/projects/rad/.tox/.tmp/package/4/rad-0.14.3.dev12%2Bg944ccb0.tar.gz#sha256=fb0f2f0700116b88dfd29ff866c012f6d5fd37341ec1274408bf8c248777a31e
semantic-version==2.10.0
zipp==3.15.0

@zacharyburnett zacharyburnett marked this pull request as ready for review May 10, 2023 14:38
@zacharyburnett zacharyburnett requested review from a team and WilliamJamieson as code owners May 10, 2023 14:38
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit ceededa into spacetelescope:main May 11, 2023
@zacharyburnett zacharyburnett deleted the devdeps_fix branch May 11, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants