Rcal 738 Process data with at least 16 resultants (SOC-1069 & SOC-1070)

[ddavis-stsci]

Resolves RCAL-738
Resolves RCAL-740

Closes #1047 #1048

This PR adds tests for processing data with 16 resultants for imaging a spectral data.
For imaging

INFO     stpipe.ExposurePipeline.tweakreg:log_config.py:142 TweakRegStep instance created.
2024-01-10 14:29:37,642 - stpipe.ExposurePipeline - INFO - DMS413 MSG: Testing that result is a Level 2 model.......Pass
INFO     stpipe.ExposurePipeline:log_config.py:142 DMS413 MSG: Testing that result is a Level 2 model.......Pass
2024-01-10 14:29:37,642 - stpipe.ExposurePipeline - INFO - DMS413 MSG: Testing that there are 16 resultants in the input file.......Pass
INFO     stpipe.ExposurePipeline:log_config.py:142 DMS413 MSG: Testing that there are 16 resultants in the input file.......Pass
2024-01-10 14:29:37,642 - stpipe.ExposurePipeline - INFO - DMS413 MSG: Testing that there are 16 resultants listed in the output file.......Pass
INFO     stpipe.ExposurePipeline:log_config.py:142 DMS413 MSG: Testing that there are 16 resultants listed in the output file.......Pass
2024-01-10 14:29:37,642 - stpipe - INFO - METRIC - DMS413 - test_16resultants_image_processing - PASS
INFO     stpipe:log_config.py:142 METRIC - DMS413 - test_16resultants_image_processing - PASS
INFO     stpipe:log_config.py:142 METRIC - DMS413 - test_16resultants_image_processing - PASS
PASSED

For the spectral data

INFO     stpipe.ExposurePipeline:log_config.py:142 DMS414 MSG: Testing that result is a Level 2 model.......Pass
2024-01-10 14:42:42,594 - stpipe.ExposurePipeline - INFO - DMS414 MSG: Testing that there are 16 resultants in the input file.......Pass
INFO     stpipe.ExposurePipeline:log_config.py:142 DMS414 MSG: Testing that there are 16 resultants in the input file.......Pass
2024-01-10 14:42:42,594 - stpipe.ExposurePipeline - INFO - DMS414 MSG: Testing that there are 16 resultants listed in the output file.......Pass
INFO     stpipe.ExposurePipeline:log_config.py:142 DMS414 MSG: Testing that there are 16 resultants listed in the output file.......Pass
2024-01-10 14:42:42,594 - stpipe - INFO - METRIC - DMS414 - test_16resultants_spectral_processing - PASS
INFO     stpipe:log_config.py:142 METRIC - DMS414 - test_16resultants_spectral_processing - PASS
INFO     stpipe:log_config.py:142 METRIC - DMS414 - test_16resultants_spectral_processing - PASS

Checklist

• [N/A] added entry in CHANGES.rst under the corresponding subsection
• updated relevant tests
• [N/A] updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
  https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/532/

[schlafly]

This looks good to me. One question: in principle we could ask RTB to put one of these files into CRDS, and we could make our default files use them. The we could just add additional logging to the existing tests rather than create new ones, and we wouldn't be dependent on another set of separately created files. Is that direction worth pursuing?

[ddavis-stsci]

Yes, we should pursue that. I'd like to see the 16 resultant data and dark files be on the INS list of "standard" files to generate and have the dark ref files in CRDS. I'm assuming that there will be a MA table for 16 resultants at some point, I don't know if we have one currently.

…

On 1/11/24 8:22 AM, Eddie Schlafly wrote: ***@***.**** commented on this pull request. This looks good to me. One question: in principle we could ask RTB to put one of these files into CRDS, and we could make our default files use them. The we could just add additional logging to the existing tests rather than create new ones, and we wouldn't be dependent on another set of separately created files. Is that direction worth pursuing? — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/spacetelescope/romancal/pull/1059*pullrequestreview-1815573260__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!1ydztPnRuQAueviwCzAu54cWPZjtF9Eq7PWhRtoDyxmGiUlFTfMu6ig5WWtnsdcZnkwAEw8ScLCn__-wZbgittHL$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ALXCXWPSCLJOEF3NEH5PTMTYN7RRNAVCNFSM6AAAAABBWOFZO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJVGU3TGMRWGA__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!1ydztPnRuQAueviwCzAu54cWPZjtF9Eq7PWhRtoDyxmGiUlFTfMu6ig5WWtnsdcZnkwAEw8ScLCn__-wZUQipVXt$>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (abb48b2) to head (4340fbe).
Report is 467 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files         105      105           
  Lines        7015     7015           
=======================================
  Hits         5382     5382           
  Misses       1633     1633           

Flag	Coverage Δ		*Carryforward flag
nightly	63.02% <ø> (ø)		Carriedforward from 531ccc3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.